From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH]: Add IcedTea 6
Date: Thu, 29 Jan 2015 10:47:17 +0100
Message-ID: <idjr3ud7wbe.fsf@bimsb-sys02.mdc-berlin.net>
References: <idj1tmg8ci7.fsf@bimsb-sys02.mdc-berlin.net>
	<87386vubwl.fsf@gnu.org>
	<idjtwza7vq3.fsf@bimsb-sys02.mdc-berlin.net>
	<8761bqq3wn.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47831)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1YGlhB-00047V-1a
	for guix-devel@gnu.org; Thu, 29 Jan 2015 04:47:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1YGlh8-0006iK-6P
	for guix-devel@gnu.org; Thu, 29 Jan 2015 04:47:28 -0500
In-Reply-To: <8761bqq3wn.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>

Ludovic Court=C3=A8s writes:
>> I rewrote this to instead check the generated test logs in test/ for
>> lines starting with "Error:" or "FAILED:".  To disable tests I wrapped
>> it in an (or #t ...) as the argument #:tests? #f does not disable a
>> custom check phase.
>>
>>              'check
>>              (lambda _
>>                ;; The "make check-*" targets always return zero, so we=
 need to
>>                ;; check for errors in the associated log files to dete=
rmine
>>                ;; whether any tests have failed.
>>                (use-modules (ice-9 rdelim))
>>                (let* ((error-pattern (make-regexp "^(Error|FAILED):.*"=
))
>>                       (checker (lambda (port)
>>                                  (let loop ((_ #t))
>
> You can make it (let loop () ... (loop)).

Ah, right.  Fixed.

> One last thing: perhaps we can directly remove mips64el-linux from
> =E2=80=98supported-platforms=E2=80=99?

Is it known to not build on mips64el?

> OK to push. =20

I pushed without disabling any platform yet.  Based on the build results
I will update the package.

> Thanks,
> Ludo=E2=80=99.

Cheers,
Ricardo