From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] Fix and update pbtranscript-tofu.
Date: Wed, 28 Oct 2015 16:34:16 +0100
Message-ID: <idjr3kf57nr.fsf@bimsb-sys02.mdc-berlin.net>
References: <idjvb9r5clp.fsf@bimsb-sys02.mdc-berlin.net>
	<8737wv823t.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47527)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1ZrSk8-0001hD-4B
	for guix-devel@gnu.org; Wed, 28 Oct 2015 11:34:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1ZrSk4-0004Ed-3F
	for guix-devel@gnu.org; Wed, 28 Oct 2015 11:34:28 -0400
In-Reply-To: <8737wv823t.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>


Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>
>> From eec9e45e681b5f2c85db8a5a60a0d55e132e62a1 Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
>> Date: Wed, 28 Oct 2015 14:39:13 +0100
>> Subject: [PATCH] gnu: pbtranscript-tofu: Update to 2.2.3.
>>
>> * gnu/packages/bioinformatics.scm (pbtranscript-tofu): Update to 2.2.3=
.
>>   [source]: Remove bundled Cython sources in a snippet.  Drop ".tar.gz=
"
>>   extension from file-name field.
>>   [arguments]: Replace "enter-directory-and-clean-up" phase with
>>   "enter-directory" phase, and add "patch-setuppy" phase.
>>   [inputs]: Add python2-h5py.  Move python2-cython ...
>>   [native-inputs]: ... to this field.
>
> [...]
>
>>        (source (origin
>>                  (method git-fetch)
>>                  (uri (git-reference
>>                        (url "https://github.com/PacificBiosciences/cDN=
A_primer.git")
>>                        (commit commit)))
>> -                (file-name (string-append name "-" version ".tar.gz")=
)
>> +                (file-name (string-append name "-" version))
>
> Could you append =E2=80=9C-checkout=E2=80=9D to the file name, to diffe=
rentiate it from
> the build result?

Amended and pushed.  Thanks for the review!

~~ Ricardo