From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add xz-java.
Date: Wed, 27 Apr 2016 11:04:21 +0200 [thread overview]
Message-ID: <idjpotb778q.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <87a8kg10zb.fsf@gnu.org>
Roel Janssen <roel@gnu.org> writes:
> Ricardo Wurmus writes:
>
>> Hi Roel,
>>
>>> Ricardo Wurmus writes:
>>>
>>>> Roel Janssen <roel@gnu.org> writes:
>>>>
>>>>> One minor detail is the filename of the jar. I renamed it to
>>>>> "xz-1.5.jar", which I think is the "standard" file naming scheme for our
>>>>> Java packages.
>>>>
>>>> I think it’s a bit ugly because we have the version number in the target
>>>> directory already, but I realise that this is how the jar is originally
>>>> named, so I think that’s okay.
>>>
>>> The jar is originally named "xz.jar". I thought other Java packages
>>> included the version number in the filename, so I just followed this
>>> practice.
>>>
>>> Either "xz.jar" or "xz-1.5.jar" is fine with me.
>>>
>>>> However, we should not hardcode the version string. Instead we should
>>>> do something like this (untested):
>>>>
>>>> #:jar-name ,(string-append "xz-" version ".jar")
>>>>
>>>> What do you think? If this works for you I’ll commit your patch with
>>>> this change.
>>>
>>> I've just tested it and it works. Since you're better at making a
>>> stylistic decision, I want to leave it up to you whether you want to
>>> append the version number or not. Both ways are fine with me.
>>
>> I forgot to reply to this message and I no longer remember what we
>> should do. Do you have an updated patch for “java-xz” (with or without
>> version number)?
>
> Yes, here it is. So, I renamed it to "java-xz" due to the naming
> conventions. I applied your suggestion of making the version a variable
> in the #:jar-name field.
Thank you! I pushed it to master.
~~ Ricardo
prev parent reply other threads:[~2016-04-27 9:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 21:34 [PATCH] gnu: Add xz-java Roel Janssen
2016-04-01 9:42 ` Ricardo Wurmus
2016-04-01 11:25 ` Roel Janssen
2016-04-01 12:45 ` Ricardo Wurmus
2016-04-04 12:32 ` Roel Janssen
2016-04-26 14:53 ` Ricardo Wurmus
2016-04-26 22:03 ` Roel Janssen
2016-04-27 9:04 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjpotb778q.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=guix-devel@gnu.org \
--cc=roel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).