From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] Add IcedTea 7.
Date: Tue, 28 Apr 2015 12:10:32 +0200
Message-ID: <idjmw1sef6v.fsf@bimsb-sys02.mdc-berlin.net>
References: <idjfv7tvfdh.fsf@bimsb-sys02.mdc-berlin.net>
	<87y4libmyw.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56576)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1Yn2TV-0001mH-Dj
	for guix-devel@gnu.org; Tue, 28 Apr 2015 06:10:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1Yn2TR-00076K-VX
	for guix-devel@gnu.org; Tue, 28 Apr 2015 06:10:45 -0400
In-Reply-To: <87y4libmyw.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>


Ludovic Court=C3=A8s writes:

>> * gnu/packages/java.scm (icedtea7): New variable.
>
> [...]
>
>> +         #:locale "C"
>
> Could you add a comment explaining why?

Done

>> +         ,@(substitute-keyword-arguments `(#:modules ((guix build gnu=
-build-system)
>> +                                                      (guix build uti=
ls)
>> +                                                      (srfi srfi-1)
>> +                                                      (srfi srfi-26))
>> +                                                     ,@(package-argum=
ents icedtea6))
>
> The ,@ should be aligned with #:modules (unfortunately Emacs fails to d=
o
> that by default.)

I noticed that the #:modules stuff was not actually required, so it
looks nicer now.

>
>> +             ((#:phases phases)
>> +              `(alist-replace
>
> This is typically a case where =E2=80=98modify-phases=E2=80=99 would be=
 more readable,
> if you feel like changing it.

I rewrote this to use the 'modify-phase' syntax and pushed to master.
Thank you for the review!

~~ Ricardo