From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] gnu: Add perltidy. Date: Tue, 5 Jul 2016 13:01:07 +0200 Message-ID: References: <87oa6c5uty.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43812) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKO6S-0007p8-EA for guix-devel@gnu.org; Tue, 05 Jul 2016 07:01:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKO6N-0005rJ-J8 for guix-devel@gnu.org; Tue, 05 Jul 2016 07:01:20 -0400 In-Reply-To: <87oa6c5uty.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Roel Janssen Cc: guix-devel Roel Janssen writes: > Here I have a package recipe for perltidy. The version number differs > from the usual scheme, but that's what the project uses, so I cannot do > much about it. I don=E2=80=99t think that=E2=80=99s a problem. >>From d6cc1580a362f759bbd85107435a47c0eac04954 Mon Sep 17 00:00:00 2001 > From: Roel Janssen > Date: Tue, 5 Jul 2016 10:51:58 +0200 > Subject: [PATCH] gnu: Add perltidy. > > * gnu/packages/perl.scm (perltidy): New variable. > --- > gnu/packages/perl.scm | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm > index 74a47b4..e34515e 100644 > --- a/gnu/packages/perl.scm > +++ b/gnu/packages/perl.scm > @@ -9,6 +9,7 @@ > ;;; Copyright =C2=A9 2016 Efraim Flashner > ;;; Coypright =C2=A9 2016 ng0 > ;;; Copyright =C2=A9 2016 Alex Sassmannshausen > +;;; Copyright =C2=A9 2016 Roel Janssen > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -5986,6 +5987,27 @@ system.") > as exceptions to standard program flow.") > (license (package-license perl)))) > =20 > +(define-public perltidy > + (package > + (name "perltidy") =E2=80=9Cperltidy=E2=80=9D (as in the domain name) or =E2=80=9Cperl-tidy=E2= =80=9D (as in the tarball)? I don=E2=80=99t remember what our naming guidelines say about this. (I t= hink =E2=80=9Cperltidy=E2=80=9D is correct.) > + (version "20160302") > + (source (origin > + (method url-fetch) > + (uri (string-append "mirror://sourceforge/perltidy/Perl-= Tidy-" > + version ".tar.gz")) > + (file-name (string-append name "-" version ".tar.gz")) Is this necessary or can we just keep the tarball name as it is? > + (sha256 > + (base32 > + "19yw63yh5s3pq7k3nkw6nsamg5b8vvwyhgbizslgxg0mqgc4xl3d"= )))) > + (build-system perl-build-system) > + (home-page "http://perltidy.sourceforge.net/") > + (synopsis "Perl script tidier") > + (description "This package contains a Perl script which indents an= d > +reformats Perl scripts to make them easier to read. The formatting c= an be > +controlled with command line parameters. The default parameter settin= gs > +approximately follow the suggestions in the Perl Style Guide.") > + (license gpl2+))) > + The rest looks good to me. Thanks! ~~ Ricardo