From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add perltidy.
Date: Tue, 5 Jul 2016 13:01:07 +0200 [thread overview]
Message-ID: <idjmvlwuz64.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <87oa6c5uty.fsf@gnu.org>
Roel Janssen <roel@gnu.org> writes:
> Here I have a package recipe for perltidy. The version number differs
> from the usual scheme, but that's what the project uses, so I cannot do
> much about it.
I don’t think that’s a problem.
>From d6cc1580a362f759bbd85107435a47c0eac04954 Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Tue, 5 Jul 2016 10:51:58 +0200
> Subject: [PATCH] gnu: Add perltidy.
>
> * gnu/packages/perl.scm (perltidy): New variable.
> ---
> gnu/packages/perl.scm | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index 74a47b4..e34515e 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -9,6 +9,7 @@
> ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
> ;;; Coypright © 2016 ng0 <ng0@we.make.ritual.n0.is>
> ;;; Copyright © 2016 Alex Sassmannshausen <alex@pompo.co>
> +;;; Copyright © 2016 Roel Janssen <roel@gnu.org>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -5986,6 +5987,27 @@ system.")
> as exceptions to standard program flow.")
> (license (package-license perl))))
>
> +(define-public perltidy
> + (package
> + (name "perltidy")
“perltidy” (as in the domain name) or “perl-tidy” (as in the tarball)?
I don’t remember what our naming guidelines say about this. (I think
“perltidy” is correct.)
> + (version "20160302")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "mirror://sourceforge/perltidy/Perl-Tidy-"
> + version ".tar.gz"))
> + (file-name (string-append name "-" version ".tar.gz"))
Is this necessary or can we just keep the tarball name as it is?
> + (sha256
> + (base32
> + "19yw63yh5s3pq7k3nkw6nsamg5b8vvwyhgbizslgxg0mqgc4xl3d"))))
> + (build-system perl-build-system)
> + (home-page "http://perltidy.sourceforge.net/")
> + (synopsis "Perl script tidier")
> + (description "This package contains a Perl script which indents and
> +reformats Perl scripts to make them easier to read. The formatting can be
> +controlled with command line parameters. The default parameter settings
> +approximately follow the suggestions in the Perl Style Guide.")
> + (license gpl2+)))
> +
The rest looks good to me. Thanks!
~~ Ricardo
next prev parent reply other threads:[~2016-07-05 11:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 8:54 [PATCH] gnu: Add perltidy Roel Janssen
2016-07-05 11:01 ` Ricardo Wurmus [this message]
2016-07-05 11:10 ` Roel Janssen
2016-07-05 13:57 ` Ricardo Wurmus
2016-07-05 14:15 ` Roel Janssen
2016-07-09 19:01 ` Andreas Enge
2016-07-10 10:48 ` Roel Janssen
2016-07-10 13:27 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjmvlwuz64.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=guix-devel@gnu.org \
--cc=roel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).