From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] openblas on MIPS. Date: Fri, 30 Oct 2015 13:43:37 +0100 Message-ID: References: <87a8r18l9f.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zs926-0001vX-Gq for guix-devel@gnu.org; Fri, 30 Oct 2015 08:43:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zs922-0004Qa-Fn for guix-devel@gnu.org; Fri, 30 Oct 2015 08:43:50 -0400 In-Reply-To: <87a8r18l9f.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: >> * gnu/packages/maths.scm (openblas)[arguments]: Add "TARGET=3DSICORTEX= " to >> make-flags when building for MIPS. > > Sounds good but=E2=80=A6 > >> - '("DYNAMIC_ARCH=3D1") >> - ;; On MIPS we force the SICORTEX TARGET, as for th= e other >> - ;; two available MIPS targets special Loongson ext= ended >> - ;; instructions are used. >> - (if (string-prefix? "mips" (%current-system)) >> - '("TARGET=3DSICORTEX") > > This doesn=E2=80=99t seem to be a patch against master, is it? Here=E2=80=99s the corrected patch: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename="0001-gnu-openblas-Set-TARGET-to-SICORTEX-on-MIPS.patch" >From 99bdf62c3ff47ad3cb3a57092ed96baa1055fa77 Mon Sep 17 00:00:00 2001 From: Ricardo Wurmus Date: Mon, 20 Jul 2015 15:05:55 +0200 Subject: [PATCH 1/2] gnu: openblas: Set TARGET to SICORTEX on MIPS. * gnu/packages/maths.scm (openblas)[arguments]: Add "TARGET=SICORTEX" to make-flags when building for MIPS. --- gnu/packages/maths.scm | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm index 4935f80..b5abc48 100644 --- a/gnu/packages/maths.scm +++ b/gnu/packages/maths.scm @@ -1491,10 +1491,16 @@ constant parts of it.") ;; Unfortunately, this is not supported on non-x86 architectures, ;; where it leads to failed builds. ,@(let ((system (or (%current-target-system) (%current-system)))) - (if (or (string-prefix? "x86_64" system) + (cond + ((or (string-prefix? "x86_64" system) (string-prefix? "i686" system)) - '("DYNAMIC_ARCH=1") - '()))) + '("DYNAMIC_ARCH=1")) + ;; On MIPS we force the "SICORTEX" TARGET, as for the other + ;; two available MIPS targets special extended instructions + ;; for Loongson cores are used. + ((string-prefix? "mips" system) + '("TARGET=SICORTEX")) + (else '())))) ;; no configure script #:phases (alist-delete 'configure %standard-phases))) (inputs -- 2.1.0 --=-=-=--