From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] Add libconfig. Date: Thu, 10 Dec 2015 15:47:10 +0100 Message-ID: References: <878u52be92.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a72V8-0003MI-Og for guix-devel@gnu.org; Thu, 10 Dec 2015 09:47:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a72V5-0003EQ-GZ for guix-devel@gnu.org; Thu, 10 Dec 2015 09:47:22 -0500 In-Reply-To: <878u52be92.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Roel Janssen Cc: guix-devel@gnu.org Hi Roel, > This is a patch to add libconfig. It's a simple library without any > special dependencies. The reason to add this, is because I'm packaging > other software that depends on libconfig. > > I ran guix lint on it, but I still have a problem with TLS, so I'm not > 100% confident running guix lint is clean. Please let me know if > something is wrong with the patch. this looks really good. Thank you. > From a21ebd71a39bf5000e5809514f0e00185311795d Mon Sep 17 00:00:00 2001 > From: Roel Janssen > Date: Thu, 10 Dec 2015 14:45:47 +0100 > Subject: [PATCH] gnu: Add libconfig. > * gnu/packages/libconfig.scm: New file. > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. I have an irrational desire to group similar package expressions in modules rather than to add new modules. In this case we have =E2=80=9Ctextutils.scm=E2=80=9D and =E2=80=9Cxml.scm=E2=80=9D that seem r= elated. Someone else should say whether a new module for this is better than grouping it with one of the above modules. If a new module is indeed warranted the commit message is perfect. > +(define-public libconfig > + (package > + (name "libconfig") > + (version "1.5") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "http://www.hyperrealm.com/libconfig/libconfig-" > + version ".tar.gz")) > + (sha256 > + (base32 > + "1xh3hzk63v4y8815lc5209m3s6ms2cpgw4h5hg462i4f1lwsl7g3"= )))) > + (build-system gnu-build-system) > + (home-page "http://www.hyperrealm.com/libconfig/") > + (synopsis "C/C++ configuration file library") > + (description > + "Libconfig is a simple library for manipulating structured config= uration > +files. This file format is more compact and more readable than XML. = And > +unlike XML, it is type-aware, so it is not necessary to do string pars= ing in > +application code.") > + (license license:lgpl2.1))) The license is actually =E2=80=9Clgpl2.1+=E2=80=9D because the file heade= rs say this: =E2=80=9Ceither version 2.1 of the License, or (at your option) any l= ater version.=E2=80=9D Other than that it looks perfect to me. Thanks again! ~~ Ricardo