From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] Add FASTX Toolkit.
Date: Thu, 16 Apr 2015 10:31:25 +0200
Message-ID: <idjk2xcxyn6.fsf@bimsb-sys02.mdc-berlin.net>
References: <idjr3rmyds2.fsf@bimsb-sys02.mdc-berlin.net>
	<87lhhtximr.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38109)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1YifD1-0002cn-8G
	for guix-devel@gnu.org; Thu, 16 Apr 2015 04:31:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1YifCw-0008Ui-68
	for guix-devel@gnu.org; Thu, 16 Apr 2015 04:31:39 -0400
In-Reply-To: <87lhhtximr.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>


Ludovic Court=C3=A8s writes:

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>
>> "fastx-toolkit" installs three m4 files to "$out/share/aclocal", and
>> libgtextutils installs an empty "$out/share/aclocal" directoy.  I
>> reported this upstream, but I did not add a phase to remove these file=
s,
>> because I think it's not a big deal.  Is this okay or should I modify
>> the sources to avoid installing these files?
>
> What=E2=80=99s wrong with these files?  It looks fine to me, and it=E2=80=
=99s the
> standard directory for Autoconf macros.  So no problem IMO.  :-)

They are not necessary to use fastx-toolkit, so I'd rather avoid the
clutter.  The author seems to agree and is willing to accept patches to
fix this.

>> +    (home-page "http://hannonlab.cshl.edu/fastx_toolkit")
>
> Maybe the github.com URL?

Okay.

I pushed the two commits with the suggested changes.  Thanks for the
review!

~~ Ricardo