From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add FASTX Toolkit.
Date: Thu, 16 Apr 2015 10:31:25 +0200 [thread overview]
Message-ID: <idjk2xcxyn6.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <87lhhtximr.fsf@gnu.org>
Ludovic Courtès writes:
> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>
>> "fastx-toolkit" installs three m4 files to "$out/share/aclocal", and
>> libgtextutils installs an empty "$out/share/aclocal" directoy. I
>> reported this upstream, but I did not add a phase to remove these files,
>> because I think it's not a big deal. Is this okay or should I modify
>> the sources to avoid installing these files?
>
> What’s wrong with these files? It looks fine to me, and it’s the
> standard directory for Autoconf macros. So no problem IMO. :-)
They are not necessary to use fastx-toolkit, so I'd rather avoid the
clutter. The author seems to agree and is willing to accept patches to
fix this.
>> + (home-page "http://hannonlab.cshl.edu/fastx_toolkit")
>
> Maybe the github.com URL?
Okay.
I pushed the two commits with the suggested changes. Thanks for the
review!
~~ Ricardo
prev parent reply other threads:[~2015-04-16 8:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 14:39 [PATCH] Add FASTX Toolkit Ricardo Wurmus
2015-04-15 20:05 ` Ludovic Courtès
2015-04-16 8:31 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjk2xcxyn6.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).