From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Leo Famulari <leo@famulari.name>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [PATCH] Add python-tables.
Date: Mon, 13 Jun 2016 17:02:38 +0200 [thread overview]
Message-ID: <idjk2htxhbl.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <20160424191242.GB9128@jasmine>
Leo Famulari <leo@famulari.name> writes:
> On Thu, Apr 21, 2016 at 05:28:58PM +0200, Ricardo Wurmus wrote:
>> Subject: [PATCH] gnu: Add python-tables.
>
>> + (arguments
>> + `(#:configure-flags
>> + (list (string-append "--hdf5="
>> + (assoc-ref %build-inputs "hdf5")))
>> + ;; FIXME: python-build-system does not pass configure-flags to "build"
>> + ;; or "check", so we must override the build and check phases.
>
> Does setting #:configure-flags have any effect at all?
No, unfortunately, it does not. I think we should improve the
python-build-system here.
Thanks for the review! I’ll push it after removing the configure-flags
and addressing Ben’s question.
~~ Ricardo
prev parent reply other threads:[~2016-06-13 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 15:28 [PATCH] Add python-tables Ricardo Wurmus
2016-04-24 19:12 ` Leo Famulari
2016-06-13 15:02 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjk2htxhbl.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).