From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] GCJ: run libjava tests.
Date: Thu, 22 Oct 2015 16:58:10 +0200 [thread overview]
Message-ID: <idjio5zx859.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <idjmvvbxbp3.fsf@bimsb-sys02.mdc-berlin.net>
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
> Andreas Enge <andreas@enge.fr> writes:
>
>> On Thu, Oct 22, 2015 at 01:07:25PM +0200, Ricardo Wurmus wrote:
>>> ((#:phases phases)
>>> `(modify-phases ,phases
>>> + (replace 'check
>>> + (lambda _ (zero? (system* "make" "check-target-libjava"))))
>>
>> Could this be replaced by
>> #:test-target "check-target-libjava"
>> ? Apart from that, your patch looks very useful.
>
> Ah, good idea. I’m trying to build GCJ right now by adding this
>
> ((#:tests? _) #t)
> ((#:test-target _) "check-target-libjava")
>
> to the ‘substitute-keyword-arguments’ expression instead of replacing
> the “check” phase. If this works I’ll push an updated patch.
Sadly, this doesn’t work. When tests are re-enabled *all* tests are
run, including tests for g++, no matter what I set as a test target.
I don’t know why. Do you have any ideas?
~~ Ricardo
next prev parent reply other threads:[~2015-10-22 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 11:07 [PATCH] GCJ: run libjava tests Ricardo Wurmus
2015-10-22 12:33 ` Andreas Enge
2015-10-22 13:41 ` Ricardo Wurmus
2015-10-22 14:58 ` Ricardo Wurmus [this message]
2015-10-23 8:30 ` Andreas Enge
2015-10-25 21:48 ` Ludovic Courtès
2015-10-27 10:59 ` Ricardo Wurmus
2015-10-27 12:28 ` Ludovic Courtès
2015-10-27 14:39 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjio5zx859.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=andreas@enge.fr \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).