From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Ben Woodcroft <donttrustben@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] guix: ruby-build-system: Extract gemspec during 'configure'.
Date: Tue, 24 May 2016 14:14:33 +0200 [thread overview]
Message-ID: <idjeg8r4pqu.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <1463872621-17738-2-git-send-email-donttrustben@gmail.com>
Hi Ben,
I’m in favour of this change. I agree with Dave that the name of this
phase should not be “configure”.
> * guix/build/ruby-build-system.scm [build]: Move extraction from here ...
> [configure]: ... to here. New variable.
> [first-gemspec]: New variable.
> [standard-phases]: Add 'configure'.
I think these should be round parentheses. Also “standard-phases”
should really be “%standard-phases”.
~~ Ricardo
next prev parent reply other threads:[~2016-05-24 12:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-21 23:16 [PATCH 0/2]: ruby-build-system: Extract gemspec during configure Ben Woodcroft
2016-05-21 23:17 ` [PATCH 1/2] guix: ruby-build-system: Extract gemspec during 'configure' Ben Woodcroft
2016-05-24 12:14 ` Ricardo Wurmus [this message]
2016-05-25 12:42 ` Ben Woodcroft
2016-05-21 23:17 ` [PATCH 2/2] gnu: ruby-nokogiri: Update to 1.6.7.2 Ben Woodcroft
2016-05-22 2:14 ` [PATCH 0/2]: ruby-build-system: Extract gemspec during configure Thompson, David
2016-05-22 5:18 ` Ben Woodcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjeg8r4pqu.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=donttrustben@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).