From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: gcj: remove broken symlink and stump binaries.
Date: Thu, 30 Apr 2015 18:29:32 +0200 [thread overview]
Message-ID: <idjd22leg0j.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <87pp6ly52e.fsf@gnu.org>
Ludovic Courtès writes:
>> + (for-each delete-file
>> + (map (cut string-append out <>)
>> + '("/lib/jvm/jre/lib/amd64/libjawt.so"
>> + "/bin/c++"
>> + "/bin/cpp"
>> + "/bin/g++"
>> + "/bin/gcc"
>> + "/bin/gcc-ar"
>> + "/bin/gcc-nm"
>> + "/bin/gcc-ranlib"
>> + "/bin/x86_64-unknown-linux-gnu-c++"
>> + "/bin/x86_64-unknown-linux-gnu-g++"
>> + "/bin/x86_64-unknown-linux-gnu-gcc"
>> + "/bin/x86_64-unknown-linux-gnu-gcc-4.8.4"
>> + "/bin/x86_64-unknown-linux-gnu-gcc-ar"
>> + "/bin/x86_64-unknown-linux-gnu-gcc-nm"
>> + "/bin/x86_64-unknown-linux-gnu-gcc-ranlib"))))
>
> This is specific to x86_64-linux-gnu though. Wouldn’t it be better to
> use a white list instead, or maybe keep it a black list but use
> find-files and regexps?
Argh, you are of course right about this. I'll update this to use
find-files instead.
~~ Ricardo
next prev parent reply other threads:[~2015-04-30 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 15:37 [PATCH] gnu: gcj: remove broken symlink and stump binaries Ricardo Wurmus
2015-04-30 16:05 ` Ludovic Courtès
2015-04-30 16:29 ` Ricardo Wurmus [this message]
2015-05-02 16:14 ` Ricardo Wurmus
2015-05-02 18:26 ` Ludovic Courtès
2015-05-02 19:09 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjd22leg0j.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).