From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] Improve ant-build-system.
Date: Thu, 24 Mar 2016 16:57:11 +0100
Message-ID: <idjbn63rhrc.fsf@bimsb-sys02.mdc-berlin.net>
References: <idjh9fwq69t.fsf@bimsb-sys02.mdc-berlin.net>
	<20160324153341.GA27637@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45761)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1aj7dW-0004NU-C7
	for guix-devel@gnu.org; Thu, 24 Mar 2016 11:57:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1aj7dS-0005GI-B4
	for guix-devel@gnu.org; Thu, 24 Mar 2016 11:57:26 -0400
Received: from pegasus.bbbm.mdc-berlin.de ([141.80.25.20]:42982)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1aj7dR-0005FQ-RH
	for guix-devel@gnu.org; Thu, 24 Mar 2016 11:57:22 -0400
In-Reply-To: <20160324153341.GA27637@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel <guix-devel@gnu.org>


Leo Famulari <leo@famulari.name> writes:

> On Thu, Mar 24, 2016 at 03:50:38PM +0100, Ricardo Wurmus wrote:
>> Hi Guix,
>>=20
>> our ant-build-system currently throws away the jar manifest, because i=
t
>> was difficult to control its timestamp.  Without a manifest many jars
>> cannot be used, though.  Oops!
>>=20
>> The manifest and the directory it is in always get the current time,
>> which is very annoying.  Since controlling the timestamp is not possib=
le
>> with =E2=80=9Cjar=E2=80=9D, this patch repacks the jar archive with =E2=
=80=9Czip=E2=80=9D.  The only
>> thing we need to take care of is to ensure that the manifest file
>> appears first.
>
> So, the timestamp issue is avoided by using "zip"? Just curious, I woul=
d
> want to block this change regardless.

Correct.  =E2=80=9Cjar=E2=80=9D doesn=E2=80=99t just create an archive, i=
t also sets the
timestamp of the manifest.  =E2=80=9Czip=E2=80=9D doesn=E2=80=99t care ab=
out manifest timestamps
and will just take the files as they are.  Since we reset timestamps of
all files in the archive this means that the manifest will have the same
timestamp as any other file in the archive.  This makes the jar archive
reproducible.

~~ Ricardo