unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Improve ant-build-system.
Date: Thu, 24 Mar 2016 16:57:11 +0100	[thread overview]
Message-ID: <idjbn63rhrc.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <20160324153341.GA27637@jasmine>


Leo Famulari <leo@famulari.name> writes:

> On Thu, Mar 24, 2016 at 03:50:38PM +0100, Ricardo Wurmus wrote:
>> Hi Guix,
>> 
>> our ant-build-system currently throws away the jar manifest, because it
>> was difficult to control its timestamp.  Without a manifest many jars
>> cannot be used, though.  Oops!
>> 
>> The manifest and the directory it is in always get the current time,
>> which is very annoying.  Since controlling the timestamp is not possible
>> with “jar”, this patch repacks the jar archive with “zip”.  The only
>> thing we need to take care of is to ensure that the manifest file
>> appears first.
>
> So, the timestamp issue is avoided by using "zip"? Just curious, I would
> want to block this change regardless.

Correct.  “jar” doesn’t just create an archive, it also sets the
timestamp of the manifest.  “zip” doesn’t care about manifest timestamps
and will just take the files as they are.  Since we reset timestamps of
all files in the archive this means that the manifest will have the same
timestamp as any other file in the archive.  This makes the jar archive
reproducible.

~~ Ricardo

  reply	other threads:[~2016-03-24 15:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24 14:50 [PATCH] Improve ant-build-system Ricardo Wurmus
2016-03-24 15:33 ` Leo Famulari
2016-03-24 15:57   ` Ricardo Wurmus [this message]
2016-03-24 16:08     ` Leo Famulari
2016-03-31 15:23 ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=idjbn63rhrc.fsf@bimsb-sys02.mdc-berlin.net \
    --to=ricardo.wurmus@mdc-berlin.de \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).