unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [PATCH} Add cd-hit.
Date: Tue, 23 Feb 2016 14:33:26 +0100	[thread overview]
Message-ID: <idj8u2b4km1.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <56C99938.40207@uq.edu.au>


Ben Woodcroft <b.woodcroft@uq.edu.au> writes:

> +(define-public cd-hit
> +  (package
> +    (name "cd-hit")
> +    (version "4.6.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/weizhongli/cdhit/releases/download/V"
> +             version
> +             "/cd-hit-v"
> +             version
> +             "-2015-0603.tar.gz"))

I’m not a fan of this layout (in particular: distributing the string on
so many lines).

Is ‘-2015-0603’ actually part of the version number?

If so you may need to use “(version "4.6.4-2015-0603")” and strip off
the part beginning with “-” in the first instance of “version” in the
URL.

I checked the license and according to the documentation it’s really
just GPLv2.  (There are no license headers.)

~~ Ricardo

  parent reply	other threads:[~2016-02-23 13:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-21 11:02 [PATCH} Add cd-hit Ben Woodcroft
2016-02-23 13:24 ` Ludovic Courtès
2016-02-23 13:33 ` Ricardo Wurmus [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-03-11 14:18 [PATCH] Add CD-HIT Ricardo Wurmus
2016-03-11 16:02 ` Ben Woodcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=idj8u2b4km1.fsf@bimsb-sys02.mdc-berlin.net \
    --to=ricardo.wurmus@mdc-berlin.de \
    --cc=b.woodcroft@uq.edu.au \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).