Re: [PATCH] Fix subread on non-x86_64

[Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>]

Ludovic Courtès <ludo@gnu.org> writes:

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>
>> the attached patch should fix the build of subread on non-x86_64 by
>> overriding the CC and CCFLAGS variables, which by default are set to
>> contain a lot of x86_64 optimisations.
>
> Nice!  Could you add a comment explaining that?

Sure.

>> From 71a37b56d0962f0db4009bdb6a88c22025278a00 Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
>> Date: Fri, 23 Oct 2015 14:16:27 +0200
>> Subject: [PATCH] gnu: subread: Use SSE optimizations on x86_64 only.
>>
>> * gnu/packages/bioinformatics.scm (subread)[arguments]: Override CC and
>>   CCFLAGS conditionally dependent on target system.
>
> [...]
>
>> +               (if (string-prefix? "x86_64" system)
>> +                   (string-append "CCFLAGS=" (string-join (append flags flags64) " "))
>> +                   (string-append "CCFLAGS=" (string-join flags " "))))
>
> The last argument to ‘string-join’ can be omitted here.

Okay.  Pushed with the above changes.
Thanks!

~~ Ricardo