From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] gnu: add asn1c Date: Thu, 1 Sep 2016 17:09:49 +0200 Message-ID: References: <1472741879-7459-1-git-send-email-h.goebel@crazy-compilers.com> <1472741879-7459-2-git-send-email-h.goebel@crazy-compilers.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfTcx-0003tb-0o for guix-devel@gnu.org; Thu, 01 Sep 2016 11:10:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfTcq-0001JO-VP for guix-devel@gnu.org; Thu, 01 Sep 2016 11:10:01 -0400 Received: from venus.bbbm.mdc-berlin.de ([141.80.25.30]:46671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfTcq-0001JK-Fu for guix-devel@gnu.org; Thu, 01 Sep 2016 11:09:56 -0400 In-Reply-To: <1472741879-7459-2-git-send-email-h.goebel@crazy-compilers.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Hartmut Goebel Cc: guix-devel@gnu.org Hi Hartmut, > * gnu/packages/tsl.scm (asn1c): New variable. Thanks for the patch! Below are some comments about style and customs :) > gnu/packages/tls.scm | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm > index 4b87150..52136f6 100644 > --- a/gnu/packages/tls.scm > +++ b/gnu/packages/tls.scm > @@ -7,6 +7,7 @@ > ;;; Copyright =C2=A9 2015 Leo Famulari > ;;; Copyright =C2=A9 2016 Efraim Flashner > ;;; Copyright =C2=A9 2016 ng0 > +;;; Copyright =C2=A9 2016 Hartmut Goebel > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -68,6 +69,34 @@ networking, allowing for formal validation of data a= ccording to some > specifications.") > (license license:lgpl2.0+))) > =20 > +(define-public asn1c > + (package > + (name "asn1c") > + (version "0.9.27") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://lionet.info/soft/asn1c-" version ".= tar.gz")) > + (sha256 (base32 "17nvn2kzvlryasr9dzqg6gs27b9lvqpval0k31pb64bjqbh= n8pq2")))) The indentation is off. We would usually format like this: (source (origin (method url-fetch) (uri (string-append "https://lionet.info/soft/asn1c-" version ".tar.gz")) (sha256 (base32 "17nvn2kzvlryasr9dzqg6gs27b9lvqpval0k31pb64bjqbhn8pq2")))) > + (build-system gnu-build-system) > + (native-inputs > + `(("perl" ,perl))) > + (home-page "https://lionet.info/asn1c") > + (synopsis "ASN.1 to C Compiler") Please remove the extra space between =E2=80=9CC=E2=80=9D and =E2=80=9CCo= mpiler=E2=80=9D, and use lower-case for =E2=80=9CCompiler=E2=80=9D. > + (description "The ASN.1 to C compiler takes the ASN.1 module > +files (example) and generates the C++ compatible C source code. That = code can > +be used to serialize the native C structures into compact and unambigu= ous > +BER/XER/PER-based data files, and deserialize the files back. > + =E2=80=9Ctakes the ASN.1 module files ... generates the C++...=E2=80=9D =E2= =80=93> the =E2=80=9Cthe=E2=80=9D should be removed in both cases. What does =E2=80=9C(example)=E2=80=9D m= ean? > +Various ASN.1 based formats are widely used in the industry, such as t= o encode > +the X.509 certificates employed in the HTTPS handshake, to exchange co= ntrol > +data between mobile phones and cellular networks, to car-to-car commun= ication > +in intelligent transportation networks. > + > +The ASN.1 standard is large and complex and no open source compiler su= pports > +it in its entirety. The asn1c is arguably the most evolved open sourc= e ASN.1 > +compiler.") I would remove the last paragraph. If it were kept we would remove the phrase =E2=80=9Copen source=E2=80=9D. =E2=80=9Cmost evolved=E2=80=9D= sounds like an advertisement statement, which we like to keep out of descriptions. ~~ Ricardo