From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH 01/10] gnu: Add python-pytest-cov. Date: Fri, 11 Dec 2015 15:03:39 +0100 Message-ID: References: <1449153811-32039-1-git-send-email-efraim@flashner.co.il> <1449153811-32039-2-git-send-email-efraim@flashner.co.il> <87vb8fnp9l.fsf@mdc-berlin.de> <20151207212552.402adeda@debian-netbook> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7OIb-0001q1-VD for guix-devel@gnu.org; Fri, 11 Dec 2015 09:03:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7OIX-00061z-Rz for guix-devel@gnu.org; Fri, 11 Dec 2015 09:03:53 -0500 Received: from sinope.bbbm.mdc-berlin.de ([141.80.25.23]:60001) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7OIX-00061q-FN for guix-devel@gnu.org; Fri, 11 Dec 2015 09:03:49 -0500 In-Reply-To: <20151207212552.402adeda@debian-netbook> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Efraim Flashner Cc: guix-devel@gnu.org Efraim Flashner writes: > From 645f979af579abb97a69b1a8814034f4c2d9b499 Mon Sep 17 00:00:00 2001 > From: Efraim Flashner > Date: Mon, 23 Nov 2015 17:12:52 +0200 > Subject: [PATCH 01/10] gnu: Add python-pytest-cov. > * gnu/packages/python.scm (python-pytest-cov, python2-pytest-cov): New > variables. > --- > gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > index d01c1d3..280f0c9 100644 > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -1634,6 +1634,34 @@ and many external plugins.") > (define-public python2-pytest > (package-with-python2 python-pytest)) =20 > +(define-public python-pytest-cov > + (package > + (name "python-pytest-cov") > + (version "2.2.0") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "pytest-cov" version)) > + (sha256 > + (base32 > + "1lf9jsmhqk5nc4w3kzwglmdzjvmi7ajvrsnwv826j3bn0wzx8c92")))) > + (build-system python-build-system) > + (propagated-inputs > + `(("python-coverage" ,python-coverage) > + ("python-pytest" ,python-pytest))) > + (native-inputs > + `(("python-setuptools" ,python-setuptools))) > + (home-page "https://github.com/pytest-dev/pytest-cov") > + (synopsis "Pytest plugin for measuring coverage") > + (description > + "Pytest-cov produces coverage reports. It supports centralised tes= ting and > +distributed testing in both load and each modes. It also supports cov= erage > +of subprocesses.") I just noticed that I don=E2=80=99t understand the second sentence. What= does =E2=80=9Cin both load and each modes=E2=80=9D mean? Also, I think we need to use American English, so even though =E2=80=9Ccentralised=E2=80=9D looks perfectly fine to me, I believe it sh= ould be =E2=80=9Ccentralized=E2=80=9D. It would be great if you could clarify the description. If you don=E2=80= =99t have push access, I can take care of pushing the patch set then. ~~ Ricardo