unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add BLESS
Date: Fri, 6 Nov 2015 18:22:28 +0100	[thread overview]
Message-ID: <idj37wjdovf.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <87bnb7jh57.fsf@gnu.org>


Ludovic Courtès <ludo@gnu.org> writes:

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>
>> From 11496448abe3717279d5b6a5d31eedae7a1dcc89 Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
>> Date: Fri, 6 Nov 2015 15:22:26 +0100
>> Subject: [PATCH] gnu: Add BLESS.
>>
>> * gnu/packages/bioinformatics.scm (bless): New variable.
>
> Probably you should add:
>
>   Co-authored-by: Diane Trout <diane@ghic.org>
>
>> +sequencing reads} (BLESS) uses a single minimum-sized Bloo  filter is a
>                                                             ^^
> Typo.
>
> Otherwise LGTM, thanks to both of you!

Thanks for the review.  I pushed it after fixing the typo and adding the
attribution to the commit message.

~~ Ricardo

  reply	other threads:[~2015-11-06 17:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05 19:49 Bioinformatics package: Bless Diane Trout
2015-11-06 14:28 ` [PATCH] Add BLESS (was: Re: Bioinformatics package: Bless) Ricardo Wurmus
2015-11-06 15:12   ` [PATCH] Add BLESS Ludovic Courtès
2015-11-06 17:22     ` Ricardo Wurmus [this message]
2015-11-06 16:01   ` [PATCH] Add BLESS (was: Re: Bioinformatics package: Bless) Diane Trout
2015-11-06 19:14   ` [PATCH] Add BLESS Alex Kost
2015-11-06 20:03     ` Ricardo Wurmus
2015-11-06 21:16       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=idj37wjdovf.fsf@bimsb-sys02.mdc-berlin.net \
    --to=ricardo.wurmus@mdc-berlin.de \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).