[bug#45644] closed (Re: [bug#45644] [PATCH] gnu: esbuild: Update to 0.8.29.)

[bug#45644] closed (Re: [bug#45644] [PATCH] gnu: esbuild: Update to 0.8.29.)

[Ryan Prior via Guix-patches via]

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

> By the way, your patches show that they are authored by "Ryan Prior via Guix-patches via guix-patches@gnu.org". Is that the correct email address?

No, the correct email address is rprior@protonmail.com

There's maybe 15 commits in Guix that have that incorrect email address. I'm not sure where it comes from or how to get rid of it. I send my patches by running a command like:

git send-email --to=guix-patches@gnu.org --suppress-cc=self 0001-gnu-esbuild-Update-to-0.8.29.patch

Git has my correct email address:

$ git config user.email
rprior@protonmail.com

So I have to imagine that either Protonmail or your email server are changing the email address.

I don't know if it's possible with the commit-signing system you have in place to rewrite Guix repo history, or whether it would be worth it, but it would be nice to have my actual email on my commits instead of the weird munged one. If there's some behavior I can change to keep it from happening again the future I will certainly be flexible.

One thing I'm going to try (unless there's any objection) is to try sending email through a third party like mailgun instead of using Protonmail's SMTP server. If it's confusing or triggers some kind of fraud prevention mechanism to get e-mails to the list that have my Protonmail address on them but aren't actually from Protonmail's server, then the next thing I could try is to request a gnu.org email address for the purposes of contributing to GNU software.

Let me know what you think!
Ryan

Re: [bug#45644] closed (Re: [bug#45644] [PATCH] gnu: esbuild: Update to 0.8.29.)

[Tobias Geerinckx-Rice via Development of GNU Guix and the GNU System distribution.]

[-- Attachment #1: Type: text/plain, Size: 2227 bytes --]

via,

Ryan Prior via Guix-patches via 写道：
> git send-email --to=guix-patches@gnu.org --suppress-cc=self 
> 0001-gnu-esbuild-Update-to-0.8.29.patch

I (and many others) use git send-email, so it can't be directly to 
blame.  I've never used it with an explicit patch file like that, 
though, only ‘-<n>’, but that should change little.

You shouldn't bother too much with Mailgun & the like, this has 
nothing to do with Protonmail.

> So I have to imagine that either Protonmail or your email server 
> are changing the email address.

Looks like us.  It's by design.  Mailing lists *have to* change 
email addresses now.  If gnu.org sent out mail to mi^Whundreds of 
Guix users claiming to be directly from you:

  From: Ryan Prior <rprior@protonmail.com>

it would amount to a poor forgery in this age of DMARC & DKIM. 
We'd be spamholed into oblivion by every recipient who doesn't go 
through extra (manual/heuristic) trouble to whitelist known MLs. 
And rightly so.

So instead we munge the From header[0], with a note to make 
receivers aware of that fact:

  From: Ryan Prior via Guix-patches via <guix-patches@gnu.org>
  Resent-From: Ryan Prior <rprior@protonmail.com>

But this happens to every mail we resend, not only yours:

  From: Leo Famulari <leo@xxx>
  Resent-From: Leo Famulari <leo@xxx>

I can't say what went wrong, only that I routinely apply patches 
from Guix MLs through mu4e and ‘git am’ without trouble.  I think. 
The last ~dozen patches signed off by me seem fine, at least.

Leo, does this happen to any guix-patch@ or just Ryan's?

> I don't know if it's possible with the commit-signing system you 
> have in place to rewrite Guix repo history, or whether it would 
> be worth it,

No and no.  Sorry.

We also can't use .mailmap to rewrite the user-facing address. 
We'd be mapping all of guix-patches@gnu.org to you.

I can't think of a way to fix the past.  It's unfortunate, but 
we'll live.

Kind regards,

T G-R

[0]: We (Mailman?) get this part wrong, however: ‘Fu Barian via 
<beep@gnu.boop>’ looks cute, but it abuses the format & clutters 
address books everywhere with the bogus name ‘Fu Barian via’.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

Re: [bug#45644] closed (Re: [bug#45644] [PATCH] gnu: esbuild: Update to 0.8.29.)

[Tobias Geerinckx-Rice via Development of GNU Guix and the GNU System distribution.]

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

Tobias Geerinckx-Rice 写道：
> I can't say what went wrong, only that I routinely apply patches 
> from
> Guix MLs through mu4e and ‘git am’ without trouble.  I 
> think. The last
> ~dozen patches signed off by me seem fine, at least.

...no idea why I didn't actually test your actual patch that 
caused this actual question.

commit e258898862f38aa9effa33ddae7fc517b0a403f4 (HEAD -> tmp)
Author: Ryan Prior via Guix-patches via <guix-patches@gnu.org>

    gnu: Add picoev.
    
    * gnu/packages/networking.scm (picoev): New variable.
    
    Signed-off-by: Tobias Geerinckx-Rice <me@tobias.gr>

Eh,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

[bug#45644] closed (Re: [bug#45644] [PATCH] gnu: esbuild: Update to 0.8.29.)

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

On Mon, Jan 04, 2021 at 06:02:54PM +0100, Tobias Geerinckx-Rice wrote:
> Leo, does this happen to any guix-patch@ or just Ryan's?

I've been noticing it with Ryan, but I don't know for sure if it happens
with anyone else. Sometimes I remember to change Ryan's address,
sometimes I don't.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Mailman From header rewrite (was: [bug#45644] closed (Re: [bug#45644] [PATCH] gnu: esbuild: Update to 0.8.29.))

[Kyle Meyer]

Ryan Prior via Guix-patches via writes:

>> By the way, your patches show that they are authored by "Ryan Prior
>> via Guix-patches via guix-patches@gnu.org". Is that the correct email
>> address?
>
> No, the correct email address is rprior@protonmail.com
>
> There's maybe 15 commits in Guix that have that incorrect email
> address. I'm not sure where it comes from or how to get rid of it. I
> send my patches by running a command like:
>
> git send-email --to=guix-patches@gnu.org --suppress-cc=self 0001-gnu-esbuild-Update-to-0.8.29.patch
>
> Git has my correct email address:
>
> $ git config user.email
> rprior@protonmail.com
>
> So I have to imagine that either Protonmail or your email server are
> changing the email address.

To add a couple of links to what Tobias mentioned downstream, I believe
the From header rewrite is a DMARC-related mitigation on Mailman's part:

  https://wiki.list.org/DEV/DMARC
  https://docs.mailman3.org/projects/mailman/en/latest/src/mailman/handlers/docs/dmarc-mitigations.html

As far as I understand, protonmail is relevant here only in that,
depending on the Mailman configuration, the originating server's DMARC
policy will affect Mailman's decision to rewrite the From header.

> If there's some behavior I can change to keep it from happening again
> the future I will certainly be flexible.
>
> One thing I'm going to try (unless there's any objection) is to try
> sending email [...]

Here's a way that doesn't involve changing where you're sending from:
add the appropriate "From:" header to the *body* of each patch.  `git
am` will take the in-body header over the actual header.  (One use of
this technique is to include a patch from someone else in a series.)

As an example, the patch you feed to git-send-email would look something
like this:

--8<---------------cut here---------------start------------->8---
From ad2469ec86357b1a46dd63dcd17d5831969d5270 Mon Sep 17 00:00:00 2001
From: Ryan Prior <rprior@protonmail.com>
Date: Mon, 4 Jan 2021 01:47:34 +0000
Subject: [PATCH] gnu: esbuild: Update to 0.8.29.

From: Ryan Prior <rprior@protonmail.com>

* gnu/packages/web.scm (esbuild): Update to 0.8.29.

Signed-off-by: Leo Famulari <leo@famulari.name>
---
 gnu/packages/web.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 34998b94a5..20a40560e2 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -1487,7 +1487,7 @@ (define-public tidy
 (define-public esbuild
   (package
     (name "esbuild")
-    (version "0.8.27")
+    (version "0.8.29")
     (source
      (origin
        (method git-fetch)
@@ -1496,7 +1496,7 @@ (define-public esbuild
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1n9h6r3q6mik7p5j0cyybh1sdcllig0awbryrx28r03cxv4ip2ij"))
+        (base32 "142gc21aaqmx0d01vmqsg7zi85pjgi3higr4ba0m52qf3mvxd6as"))
        (modules '((guix build utils)))
        (snippet
         '(begin
-- 
2.29.2
--8<---------------cut here---------------end--------------->8---

Re: Mailman From header rewrite (was: [bug#45644] closed (Re: [bug#45644] [PATCH] gnu: esbuild: Update to 0.8.29.))

[Kyle Meyer]

Kyle Meyer writes:

> As an example, the patch you feed to git-send-email would look something
> like this:
>
> --8<---------------cut here---------------start------------->8---
> From ad2469ec86357b1a46dd63dcd17d5831969d5270 Mon Sep 17 00:00:00 2001
> From: Ryan Prior <rprior@protonmail.com>
> Date: Mon, 4 Jan 2021 01:47:34 +0000
> Subject: [PATCH] gnu: esbuild: Update to 0.8.29.
>
> From: Ryan Prior <rprior@protonmail.com>
>
> * gnu/packages/web.scm (esbuild): Update to 0.8.29.
>
> Signed-off-by: Leo Famulari <leo@famulari.name>

Oops, sorry about the spurious Signed-off-by trailer here.  I forgot to
prune that after calling format-patch with ad2469ec86.

Re: Mailman From header rewrite (was: [bug#45644] closed (Re: [bug#45644] [PATCH] gnu: esbuild: Update to 0.8.29.))

[Ryan Prior via Development of GNU Guix and the GNU System distribution.]

On Tuesday, January 5th, 2021 at 5:01 AM, Kyle Meyer <kyle@kyleam.com> wrote:

> add the appropriate "From:" header to the body of each patch. `git am` will take the in-body header over the actual header.

Thank you Kyle! I will give that a try.

Re: Mailman From header rewrite

[Sarah Morgensen]

Hello Ryan, others,

I too recently noticed that my From header is getting rewritten! My
domain is set up with DKIM, SPF, and DMARC, so I suppose this is not
surprising.

Before sending this mail, I attempted two fixes:

1. add '?include:lists.gnu.org' to my SPF record; and
2. set 'p=none;' in my DMARC record.

If this mail's From isn't munged, you'll know one of those worked! :)

On Tuesday, January 5th, 2021 at 5:01 AM, Kyle Meyer <kyle@kyleam.com> wrote:

> add the appropriate "From:" header to the body of each patch. `git am`
> will take the in-body header over the actual header.

I wonder if there is a way to automate the duplication of the "From"
header into the body of the patch?

--
Sarah

Re: Mailman From header rewrite

[Kyle Meyer]

Sarah Morgensen writes:

> On Tuesday, January 5th, 2021 at 5:01 AM, Kyle Meyer <kyle@kyleam.com> wrote:
>
>> add the appropriate "From:" header to the body of each patch. `git am`
>> will take the in-body header over the actual header.
>
> I wonder if there is a way to automate the duplication of the "From"
> header into the body of the patch?

I'm not aware of an existing way at the git level.  Here's the only
discussion I found about it on the git list:

  https://lore.kernel.org/git/305577c2-709a-b632-4056-6582771176ac@redhat.com/T/#u

As a hacky/ugly way, for those that are okay tweaking the way their
names ends up on the mailing list, they can adjust `send-email --from=`
(or sendemail.from) slightly so that it doesn't match
user.name/user.email, and then send-email should take care of adding an
in-body header for user.name/user.email.

Another option is of course to feed the patches to a custom
post-processing script that adds the in-body "From:", where the details
would depend a bit on the person's patch workflow.

Or, moving that work a bit upstream, I think it'd be fairly
straightforward to wire up a prepare-commit-msg hook that would insert
an in-body "From:" (after checking some things, like whether the commit
is being amended).  I guess the main disadvantage of handling it at this
spot is the risk of commits with in-body "From:" headers unintentionally
being merged/pushed directly to the main line (given the person has
commit access).

Re: Mailman From header rewrite

[Kyle Meyer]

Kyle Meyer writes:

> Sarah Morgensen writes:
>
>> On Tuesday, January 5th, 2021 at 5:01 AM, Kyle Meyer <kyle@kyleam.com> wrote:
>>
>>> add the appropriate "From:" header to the body of each patch. `git am`
>>> will take the in-body header over the actual header.
>>
>> I wonder if there is a way to automate the duplication of the "From"
>> header into the body of the patch?
>
> I'm not aware of an existing way at the git level.  Here's the only
> discussion I found about it on the git list [...]

Git 2.38.0 gained support for this via a --force-in-body-from option and
the associated format.forceInBodyFrom config variable.

  https://lore.kernel.org/git/20220829213837.13849-1-gitster@pobox.com/