From: Attila Lendvai <attila@lendvai.name>
To: Saku Laesvuori <saku@laesvuori.fi>
Cc: Liliana Marie Prikler <liliana.prikler@gmail.com>, guix-devel@gnu.org
Subject: Re: Should commits rather be buildable or small
Date: Sun, 10 Dec 2023 17:02:57 +0000 [thread overview]
Message-ID: <gEmbDrP9RU_ma3QZhdh48YVQLx0pJOOQD6tTmJoKeLFy6sk4e1KFw9dghtlhpJHzMoH_oD2m1ZHLBEIDHuipH06WYgyxneeVSPoMZvb5g5g=@lendvai.name> (raw)
In-Reply-To: <baafvkmdhdyeevcd6jwric4qg7e7g5lmfq2f7lhzp3aumxh3ow@3bnc5vcgab2w>
> > Define "buildable" and "unbuildable".
>
>
> I used these definitions: a buildable commit does not have build
> failures (or at least no new ones). An unbuildable commit introduces
> new build failures (in this case a lot of them).
>
> Buildable commits are safe spots to land on with time-machine in the
> sense that the packages defined in them can be used. I expect it would
> be very painful to try jumping to past commits with time-machine if a
> large portion of the commits in Guix were unbuildable.
[...]
> I guess "required" here means that in some cases Guix's policy is to
> prefer small commits over buildable commits (with the previous
> definition). I at least don't see any technical reasons why it would be
> required. The question then becomes whether that policy applies in this
> case.
FWIW, this commit policy has always bothered me as a newcomer to Guix. pretty much everywhere else it's a major offence against your colleagues to commit something that breaks the build in any way.
--
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“I will probably be asked why I don't cite the author's name? Because my philosophy teacher taught me that it sometimes jeopardizes the effects of the quote.”
— Author's name withheld.
next prev parent reply other threads:[~2023-12-10 17:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 8:42 Should commits rather be buildable or small Saku Laesvuori
2023-12-08 11:41 ` Tomas Volf
2023-12-08 12:05 ` Lars-Dominik Braun
2023-12-08 16:35 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-12-08 15:44 ` Liliana Marie Prikler
2023-12-10 15:28 ` Saku Laesvuori
2023-12-10 15:50 ` Liliana Marie Prikler
2023-12-10 17:02 ` Attila Lendvai [this message]
2023-12-10 17:50 ` Ricardo Wurmus
2023-12-10 23:20 ` Attila Lendvai
2023-12-10 23:56 ` Philip McGrath
2023-12-11 10:51 ` Attila Lendvai
2023-12-11 11:51 ` Ricardo Wurmus
2024-03-04 21:38 ` John Kehayias
2024-03-05 4:32 ` dan
2024-03-05 5:19 ` Liliana Marie Prikler
2024-03-25 1:15 ` John Kehayias
2024-03-25 3:23 ` dan
2024-03-25 3:23 ` [bug#69461] " dan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='gEmbDrP9RU_ma3QZhdh48YVQLx0pJOOQD6tTmJoKeLFy6sk4e1KFw9dghtlhpJHzMoH_oD2m1ZHLBEIDHuipH06WYgyxneeVSPoMZvb5g5g=@lendvai.name' \
--to=attila@lendvai.name \
--cc=guix-devel@gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=saku@laesvuori.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).