From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 8MhrJnVA6GXQOwAAqHPOHw:P1 (envelope-from ) for ; Wed, 06 Mar 2024 11:07:49 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 8MhrJnVA6GXQOwAAqHPOHw (envelope-from ) for ; Wed, 06 Mar 2024 11:07:49 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1709719669; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=vxwM4XPh18w35OBb8yq2eMYETH/LCprjRhmpGKej4xQ=; b=QwGdGl3u8Cf1yNIr+p/UOKKMwGhr6UQEJ42xfGXKB95qE7xwSQxJbbO4lvQBG7tKGYCVXL NE3AmSH57ixacZbAWXAxQiE6fvmbqLidAjlaPuqL9aPuvfTCkzCtM3U7DOaGLAb3Dm2jFc 4f+x3qmTDBTA66/dv+Z5jWy0kwsiyurp0Frqc9FTOnM+F0A/EC+MaeFJ4eNH90mFUQOyuY qWZFIH5ziutVG81MjrA/i72FQ0qIIS0JRPI9vDZAEfxr1AyUTTcH+f0Uh1+EelpexSDUk6 GbvkpXGeOn3/3TZWTIoK3e1TMzBbS+OAW2/z8C2p+8FVUvptACNGKJ76fu4bWQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1709719669; a=rsa-sha256; cv=none; b=CBdDOZrErY/qOd6R10BO6u70IrvWFAFohMS23HfZKnWxX2l1ozWPmrkxtwFJU0Uw2n1W8F qvn8FrJlm5zCe7m6qeLzeJ8NMtEOuWbUGcRTB8lKY/iIWNtyKoxywHUo/LDdeFYzqEj8PZ 6Kmz/pyu5U289yBbl7H/fXyZ1i4P/hi0qXQ1upphjdoExPw7KacvnguLNaZ10CpEANEkQx lqsK7CvEDISFWsQef5RbC14Nk466/yOdfsR3RJczFnz6L6ArccfxTmGrSnVB5IlRAYna5V RUm+gkTNliHA/XhWAnIbBF0jvzG/7TW6Wy/WR0c2B6AFy3qsNo8U6wrLtuJ3nQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 65393179CE for ; Wed, 6 Mar 2024 11:07:49 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhoBB-0008GV-R2; Wed, 06 Mar 2024 05:07:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhoB9-0008En-Mg for guix-devel@gnu.org; Wed, 06 Mar 2024 05:07:15 -0500 Received: from mail01.noris.net ([62.128.1.221]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhoB7-0005q1-8z; Wed, 06 Mar 2024 05:07:15 -0500 Received: from p5b394ef1.dip0.t-ipconnect.de ([91.57.78.241] helo=[192.168.110.2]) by mail01.noris.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) (envelope-from ) id 1rhoB0-0006wr-AO; Wed, 06 Mar 2024 11:07:06 +0100 Message-ID: Date: Wed, 6 Mar 2024 11:07:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: de-DE, en-US From: Hartmut Goebel Organization: crazy-compilers.com To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= Cc: guix-devel Subject: G-exps: thunk instead of top-level references? Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Noris-IP: 91.57.78.241 Received-SPF: pass client-ip=62.128.1.221; envelope-from=h.goebel@crazy-compilers.com; helo=mail01.noris.net X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, HTML_MESSAGE=0.001, MIME_HTML_ONLY=0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -5.08 X-Spam-Score: -5.08 X-Migadu-Queue-Id: 65393179CE X-TUID: 3dz/OfTiHbBg

Hi Ludio,

I'd like to get some advice:

In commit 84c3aafb5a18ad278bbb36df7b70849fe05789c8 "trytond: Avoid top-level references to other modules" your turned a top-level variable which defines into a thunk:

<https://git.savannah.gnu.org/cgit/guix.git/commit/?id=84c3aafb5a18ad278bbb36df7b70849fe05789c8>

-(define %standard-trytond-native-inputs
+(define (%standard-trytond-native-inputs)
   `(("python-dateutil" ,python-dateutil)

and the users:

     (native-inputs
-     `(,@%standard-trytond-native-inputs
+     `(,@(%standard-trytond-native-inputs)
        ("trytond-purchase" ,trytond-purchase)))


I'm about to change the uses into G-exprs (see below) and wonder whether "%standard-trytond-native-inputs" should still be a thunk or can be turned pack into a top-level variable.

-(define (%standard-trytond-native-inputs)
-  `(("python-dateutil" ,python-dateutil)
+(define %standard-trytond-native-inputs
+  (list python-dateutil

and uses

-    (native-inputs (%standard-trytond-native-inputs))
+    (native-inputs
+     (cons* trytond-account-payment-clearing
+            %standard-trytond-native-inputs))
 

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |