unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH 1/1] Fix incorrect example package recipe in docs.
  2014-09-27 23:52 [PATCH 0/1] Fix incorrect example package recipe in docs Ian Denhardt
@ 2014-09-27 22:36 ` Ian Denhardt
  2014-09-28 10:03   ` Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Denhardt @ 2014-09-27 22:36 UTC (permalink / raw)
  To: guix-devel

In the section of the manual that first explains how to write a package
recipe, the example didn't work. The fix is trivial, just use
define-public instead of define.
---
 doc/guix.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index f73ce52..813c133 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -1371,7 +1371,7 @@ package looks like this:
   #:use-module (guix build-system gnu)
   #:use-module (guix licenses))
 
-(define hello
+(define-public hello
   (package
     (name "hello")
     (version "2.8")
-- 
2.1.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 0/1] Fix incorrect example package recipe in docs.
@ 2014-09-27 23:52 Ian Denhardt
  2014-09-27 22:36 ` [PATCH 1/1] " Ian Denhardt
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Denhardt @ 2014-09-27 23:52 UTC (permalink / raw)
  To: guix-devel

I was working off of this example from the manual when trying to
package feh this afternoon, but the example had a mistake. Thanks to
the folks on irc who helped me work this out (and a number of other
issues I was having).

Ian Denhardt (1):
  Fix incorrect example package recipe in docs.

 doc/guix.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.1.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] Fix incorrect example package recipe in docs.
  2014-09-27 22:36 ` [PATCH 1/1] " Ian Denhardt
@ 2014-09-28 10:03   ` Ludovic Courtès
  0 siblings, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2014-09-28 10:03 UTC (permalink / raw)
  To: Ian Denhardt; +Cc: guix-devel

Ian Denhardt <ian@zenhack.net> skribis:

> In the section of the manual that first explains how to write a package
> recipe, the example didn't work. The fix is trivial, just use
> define-public instead of define.

Pushed, thanks!

Note that I adjusted the commit log to conform with our conventions, as
described under “Submitting Patches” in ‘HACKING’.

Ludo’.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-09-28 10:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-27 23:52 [PATCH 0/1] Fix incorrect example package recipe in docs Ian Denhardt
2014-09-27 22:36 ` [PATCH 1/1] " Ian Denhardt
2014-09-28 10:03   ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).