From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GNFPITXW7GI0GgEAbAwnHQ (envelope-from ) for ; Fri, 05 Aug 2022 10:35:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id mBY6ITXW7GIzCAEA9RJhRA (envelope-from ) for ; Fri, 05 Aug 2022 10:35:01 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 323CC126A for ; Fri, 5 Aug 2022 10:35:01 +0200 (CEST) Received: from localhost ([::1]:43032 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJsY6-0003UG-Bo for larch@yhetil.org; Fri, 05 Aug 2022 04:19:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJsSP-0006y0-Ln for guix-devel@gnu.org; Fri, 05 Aug 2022 04:13:25 -0400 Received: from baptiste.telenet-ops.be ([2a02:1800:120:4::f00:13]:38900) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJsSK-00048K-PC for guix-devel@gnu.org; Fri, 05 Aug 2022 04:13:19 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by baptiste.telenet-ops.be with bizsmtp id 3kDC2800U20ykKC01kDDrl; Fri, 05 Aug 2022 10:13:13 +0200 Message-ID: Date: Fri, 5 Aug 2022 10:13:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches. Content-Language: en-US To: Philip McGrath , Brian Cully Cc: Julien Lepiller , =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <8b13e899-eb60-490b-a268-639249698c81@www.fastmail.com> From: Maxime Devos In-Reply-To: <8b13e899-eb60-490b-a268-639249698c81@www.fastmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------70QhZikMlEFYMpkhnWHAzOPK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1659687193; bh=XABychC8BuJRmotIyfuWGv5xFzfP6u1sNqwWR9e/5c4=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=RH3XxwUtvaWseR1GId83JadQJopDmY4Wf9P20kampxRNTPUdcugQN+7tFnY2f6HPN qWXe2MfbvVdMg6xMk2eOXFv3ez03rQShXBezAMVI+xARST61t1xhc8obuKEh45wS/b gA2oaCTGXIOdWUz6h7n0r/JLiRRojuJuop6JF1Isfo4qH7znfQidoSygq/7y43CIre cKGPKMTB4ozLiSpdHbtJgnmvkX8BxIWOVBNH0yanySKNs7FYIYA0K7C2/SBZamjnA9 dTNnq4nfE/sBSpMqgcLq+mKq871ZK7BQHVYuT6ZLvlRsXVHfkucqcfYxXeB4khIBA9 gxZ5YResApgJA== Received-SPF: pass client-ip=2a02:1800:120:4::f00:13; envelope-from=maximedevos@telenet.be; helo=baptiste.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659688501; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=0ddhdSL9gtJrn1KoJv77js6PUrPwRGsIdbjrDH4SeYo=; b=rThLhVwF3wldmGRCPp9edV6YFQAE4xTsjqTSZ/sVzUcdssnnoL5TMyzHBVsMgqN7mGnnJj wUixcUgO1i5jELU0CTctbS80PLfFFDuj0oH7xfgrFChM9zda/Fx8210XC2uCWJaHk/IM+k i+fgCgqZisufuBrGTlDXTH9PEn8kBOYedipjM5pzSXYplJhkplX3iuXjm86quGdqbCz67+ n+7DKY5+7Gt8GKPpx+Fzv9l73n97Ci3oQ2TlESj+nSSpQsxODbRBe6wj6Bj07B0CmxuBTx JF14DLWnHSg1z3YxafQ+tTp85G/3jKPi85eXd8XfeDJ6XHupGEsrcHnoOjVfrA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659688501; a=rsa-sha256; cv=none; b=ahWh3HioOiuf+5Wczz1KGmJAVaBtzAaUp04KrEbvNNyQU4szHCqkI/Qe6+K5D7IziUswXJ n6/mxlTrp8IvrFXG8E2u/KlWBVjgSGqNFVMKJRNtBUnj2BwlIX0wFi178aOgGZfLvD3VKz NSsMEcSOyTDAdP8Blo5sa4TSUGowda3dPvIDGB+95CfCVMDS1tYnzk2loBtl0AQeBthVAb VCpsvRN8prem7GXztvVeO5Q0sH5dAeJIcQJMFhH2TeQT9FEv4i29BfHv60o+28i4TF2Umw 8qpwCV/YRa2sn1nCOjlBVNMvrRvRiTDAhr2/4o7FDGygIXaHwg7hsGYSF5fsGQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=telenet.be header.s=r22 header.b=RH3XxwUt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.39 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=telenet.be header.s=r22 header.b=RH3XxwUt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 323CC126A X-Spam-Score: 3.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: LdxGesgp0DeA This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------70QhZikMlEFYMpkhnWHAzOPK Content-Type: multipart/mixed; boundary="------------FSLm1rIbMecPDoE9ZQcFZuWw"; protected-headers="v1" From: Maxime Devos To: Philip McGrath , Brian Cully Cc: Julien Lepiller , =?UTF-8?Q?Ludovic_Court=c3=a8s?= Message-ID: Subject: Re: A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches. References: <8b13e899-eb60-490b-a268-639249698c81@www.fastmail.com> In-Reply-To: <8b13e899-eb60-490b-a268-639249698c81@www.fastmail.com> --------------FSLm1rIbMecPDoE9ZQcFZuWw Content-Type: multipart/mixed; boundary="------------k0jPzI6u9jnucKEG9Kw1o048" --------------k0jPzI6u9jnucKEG9Kw1o048 Content-Type: multipart/alternative; boundary="------------8CGpZpjL9wROa0ff0o8GvAyZ" --------------8CGpZpjL9wROa0ff0o8GvAyZ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAwNS0wOC0yMDIyIDA1OjIzLCBQaGlsaXAgTWNHcmF0aCB3cm90ZToNCj4gT24gU3Vu LCBKdWwgMjQsIDIwMjIsIGF0IDExOjE3IFBNLCBNYXhpbWUgRGV2b3Mgd3JvdGU6DQo+PiAg ICogUGF0Y2hlcyBtdXN0IG5vdCBiZSB1c2VkIHRvIHJlbW92ZSBub24tZnJlZSBmaWxlcywg YmVjYXVzZSBhIHBhdGNoIGJ5IGNvbnN0cnVjdGlvbiBjb250YWlucyB0aGUgbm9uLWZyZWUg ZmlsZSBpdHNlbGYgc28gdGhlIHBhdGNoIHdvdWxkIGJlIG5vbi1mcmVlLCB3aGljaCB3b3Vs ZCBub3QgYmUgYWNjZXB0YWJsZSB0byBHdWl4LiBMaWtld2lzZSwgcGF0Y2hlcyBzaG91bGQg bm90IGJlIHVzZWQgdG8gcmVtb3ZlIGJ1bmRsZWQgbGlicmFyaWVzLCB0byBhdm9pZCBsYXJn ZSBzcGFjZSB1c2FnZSwgYnV0IHRoaXMgaXMgbm90IGFuIGFic29sdXRlIHJ1bGUgdW5saWtl IGFzIGZvciBub24tZnJlZSBmaWxlcy4NCj4gSXQgaXMgcG9zc2libGUgdG8gY3JlYXRlIHBh dGNoZXMgdGhhdCBkbyBub3QgY29udGFpbiB0aGUgZGVsZXRlZCBmaWxlLCBlLmcuIHdpdGgg YGdpdCBmb3JtYXQtcGF0Y2ggLS1pcnJldmVyc2libGUtZGVsZXRlYC4gVGhhdCBzYWlkLCBJ IGRvbid0IGtub3cgaWYgdGhlIHZlcnNpb24gb2YgYHBhdGNoYCB3ZSB1c2UgdG8gcGF0Y2gg b3JpZ2lucyBpcyBhYmxlIHRvIGFwcGx5IHN1Y2ggcGF0Y2hlc+KAlGJ1dCBtYXliZSBpdCB3 b3VsZCBiZSBhIHVzZWZ1bCBmZWF0dXJlPw0KPg0KPiAtUGhpbGlwDQoNClJpZ2h0LCB0aGlz IGlzIHBvc3NpYmxlIHRob3VnaCBpdCB3b3VsZCBoYXZlIHRvIGJlIGNoZWNrZWQgd2hldGhl ciBpdCBpcyANCnN1cHBvcnRlZCwgc28gdGhhdCBzdGF0ZW1lbnQgc2hvdWxkIGJlIHdlYWtl bmVkIGEgYml0IC0tIHRvIGFsbG93IA0KZGVsZXRpbmcgbm9uLWZyZWUgZmlsZXMgd2l0aCBh IHBhdGNoLCBidXQgbm90aW5nIHRoYXQgeW91J2xsIGhhdmUgdG8gc2V0IA0KdGhlIHJpZ2h0 IG9wdGlvbnMgdG8gYXZvaWQgaW5jbHVkaW5nIHRoZSBkZWxldGVkIGZpbGUgaW4gdGhlIHBh dGNoLg0KDQpJIHdvdWxkIHJlY29tbWVuZCBhIChkZWxldGUtZmlsZS1yZWN1cnNpdmVseSAi LiIpIG92ZXIgYSBwYXRjaCBoZXJlIA0KdGhvdWdoLCB0byBhdm9pZCBoYXZpbmcgdG8gcmVt ZW1iZXIgdGhlIC0taXJyZXZlcnNpYmxlLWRlbGV0ZSBvcHRpb24gYW5kIA0KaW4gY2FzZSB0 aGVyZSBpcyBub3QgYSBnaXQgcmVwby4NCg0KR3JlZXRpbmdzLA0KTWF4aW1lLg0KDQo= --------------8CGpZpjL9wROa0ff0o8GvAyZ Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 05-08-2022 05:23, Philip McGrath wrote:
= 
On Sun, Jul 24, 2022, at 1=
1:17 PM, Maxime Devos wrote:

 * Patches must not be u=
sed to remove non-free files, because a patch by construction contains th=
e non-free file itself so the patch would be non-free, which would not be=
 acceptable to Guix. Likewise, patches should not be used to remove bundl=
ed libraries, to avoid large space usage, but this is not an absolute rul=
e unlike as for non-free files.

It is possible to create p=
atches that do not contain the deleted file, e.g. with `git format-patch =
--irreversible-delete`. That said, I don't know if the version of `patch`=
 we use to patch origins is able to apply such patches=E2=80=94but maybe =
it would be a useful feature?

-Philip

Right, this is possible though it would have to be checked whether it is supported, so that statement should be weakened a bit -- to allow deleting non-free files with a patch, but noting that you'll have to set the right options to avoid including the deleted file in the patch.

I would recommend a (delete-file-recursively ".") over a patch here though, to avoid having to remember the --irreversible-delete option and in case there is not a git repo.

Greetings,
Maxime.

--------------8CGpZpjL9wROa0ff0o8GvAyZ-- --------------k0jPzI6u9jnucKEG9Kw1o048 Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------k0jPzI6u9jnucKEG9Kw1o048-- --------------FSLm1rIbMecPDoE9ZQcFZuWw-- --------------70QhZikMlEFYMpkhnWHAzOPK Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYuzRGAUDAAAAAAAKCRBJ4+4iGRcl7hq0 AP4qZR/izrxdK3cBHgWvoMCUcFcmRmH8PrAO07wtJuZWQAEA22n0M1D7G0mi3TQe60glF9xFxagj RJ+nmwvW9JyIiAI= =oGO+ -----END PGP SIGNATURE----- --------------70QhZikMlEFYMpkhnWHAzOPK--