From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GMoYGUDk+F81QQAA0tVLHw (envelope-from ) for ; Fri, 08 Jan 2021 23:01:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4JrtFEDk+F9ddwAAbx9fmQ (envelope-from ) for ; Fri, 08 Jan 2021 23:01:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5F31C940597 for ; Fri, 8 Jan 2021 23:01:19 +0000 (UTC) Received: from localhost ([::1]:40252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ky0kw-0007gf-2l for larch@yhetil.org; Fri, 08 Jan 2021 18:01:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ky0cB-00067X-GM for guix-devel@gnu.org; Fri, 08 Jan 2021 17:52:15 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:39579) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ky0c7-00082e-Pb for guix-devel@gnu.org; Fri, 08 Jan 2021 17:52:14 -0500 X-Originating-IP: 174.89.20.211 Received: from [192.168.2.62] (bras-vprn-ckvlon0125w-lp130-02-174-89-20-211.dsl.bell.ca [174.89.20.211]) (Authenticated sender: rg@raghavgururajan.name) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 3928520003; Fri, 8 Jan 2021 22:52:04 +0000 (UTC) Subject: Re: [Telegram-Desktop]: Help with packaging To: Ricardo Wurmus , Mark H Weaver References: <671cd289-5c83-3673-34f9-8287ff7c30a8@raghavgururajan.name> <5a6392cd-b478-846a-beda-4f97e46cbdd0@raghavgururajan.name> <87sg7bfwt0.fsf@elephly.net> <874kjr15vp.fsf@netris.org> <87turrdr0o.fsf@elephly.net> From: Raghav Gururajan Message-ID: Date: Fri, 8 Jan 2021 17:52:02 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.6.0 MIME-Version: 1.0 In-Reply-To: <87turrdr0o.fsf@elephly.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=217.70.183.200; envelope-from=rg@raghavgururajan.name; helo=relay7-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.241, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.35 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 5F31C940597 X-Spam-Score: -2.35 X-Migadu-Scanner: scn0.migadu.com X-TUID: yF6m5CRn3vuB Hi Mark and Ricardo! >> It's more appropriate to use 'for-each' here. 'map' collects all of the >> results into a list and returns that list, which is not needed here, and >> is slightly less readable. Also, the second argument to 'find-files' is >> optional; omitting it does what's needed more efficiently. So, in the >> interest of promoting better practices, I would recommend this instead: >> >> --8<---------------cut here---------------start------------->8--- >> (add-after 'unpack 'make-writable >> (lambda _ >> (for-each make-file-writable >> (find-files ".")) >> #t)) >> --8<---------------cut here---------------end--------------->8--- > > Thank you for this better variant. I copied it from an existing > instance in our code. We should clean those up at some point :) This worked. :-) Regards, RG.