From: Raghav Gururajan <rg@raghavgururajan.name>
To: Ricardo Wurmus <rekado@elephly.net>, Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: [Telegram-Desktop]: Help with packaging
Date: Fri, 8 Jan 2021 17:52:02 -0500 [thread overview]
Message-ID: <f501a6a2-cb9c-ebfb-8477-8429b1f192b4@raghavgururajan.name> (raw)
In-Reply-To: <87turrdr0o.fsf@elephly.net>
Hi Mark and Ricardo!
>> It's more appropriate to use 'for-each' here. 'map' collects all of the
>> results into a list and returns that list, which is not needed here, and
>> is slightly less readable. Also, the second argument to 'find-files' is
>> optional; omitting it does what's needed more efficiently. So, in the
>> interest of promoting better practices, I would recommend this instead:
>>
>> --8<---------------cut here---------------start------------->8---
>> (add-after 'unpack 'make-writable
>> (lambda _
>> (for-each make-file-writable
>> (find-files "."))
>> #t))
>> --8<---------------cut here---------------end--------------->8---
>
> Thank you for this better variant. I copied it from an existing
> instance in our code. We should clean those up at some point :)
This worked. :-)
Regards,
RG.
next prev parent reply other threads:[~2021-01-08 23:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 1:54 [Telegram-Desktop]: Help with packaging Raghav Gururajan
2021-01-08 1:59 ` Raghav Gururajan
2021-01-08 12:11 ` Ekaitz Zarraga
2021-01-08 12:20 ` Julien Lepiller
2021-01-08 12:16 ` Ricardo Wurmus
2021-01-08 21:21 ` Mark H Weaver
2021-01-08 22:04 ` Ricardo Wurmus
2021-01-08 22:52 ` Raghav Gururajan [this message]
2021-01-09 1:59 ` Raghav Gururajan
2021-01-12 3:32 ` Raghav Gururajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f501a6a2-cb9c-ebfb-8477-8429b1f192b4@raghavgururajan.name \
--to=rg@raghavgururajan.name \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).