From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aCzTFWCHdWCABwAAgWs5BA (envelope-from ) for ; Tue, 13 Apr 2021 13:58:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id cCKzD2CHdWC2bAAAB5/wlQ (envelope-from ) for ; Tue, 13 Apr 2021 11:58:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DEDF011650 for ; Tue, 13 Apr 2021 13:58:23 +0200 (CEST) Received: from localhost ([::1]:53490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWHgV-0003Gj-2h for larch@yhetil.org; Tue, 13 Apr 2021 07:58:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWHgH-0003GT-6H for guix-devel@gnu.org; Tue, 13 Apr 2021 07:58:09 -0400 Received: from laurent.telenet-ops.be ([2a02:1800:110:4::f00:19]:36282) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWHgE-0007mp-HJ for guix-devel@gnu.org; Tue, 13 Apr 2021 07:58:08 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by laurent.telenet-ops.be with bizsmtp id sBy12400g0mfAB401By2td; Tue, 13 Apr 2021 13:58:02 +0200 Message-ID: Subject: Re: [Outreachy] - Guix Data Service - Set a more informative page title From: Maxime Devos To: Canan Talayhan , guix-devel@gnu.org Date: Tue, 13 Apr 2021 13:57:49 +0200 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-IVRNGQEm+oVXfqEpMf/1" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1618315082; bh=7PBg4OnUXR319WpfY0pOZpwhKMSbdwLhfT8m/4K6OI0=; h=Subject:From:To:Date:In-Reply-To:References; b=Kr0BLwd9mKw1Q9ie9rTq7BbzezT3/uy92s/QM98jGuBqItkGDuLZ61f5gGVRFHoQi d2MoCyLKX23/fKpSjvWNfSi7a/wqF08nhgDfsYa8+LfQQp5JWaKFBD6YTL4iSRoUme 9way7z5FCMlx/on3fw+lbcwrepJQiZ+po83DpnOI6DX7t0bu0piUA5quG/mj/6pcpp w3hm8y8Z7XJG3Qb2GrutW5lqYMI6iviD7yLpf6SdgUmYS54oCmfFOIiiPYCF99NNEQ lF8tYtGkXr7SW1AmedK+GJ0O5gckJR47YZ/C4ayngMGmBbCifOuYsYwuQ5k5nuZydL D6QeP0Hz25pHA== Received-SPF: pass client-ip=2a02:1800:110:4::f00:19; envelope-from=maximedevos@telenet.be; helo=laurent.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618315104; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7PBg4OnUXR319WpfY0pOZpwhKMSbdwLhfT8m/4K6OI0=; b=pCTlMjWFc86CdiQrr8Ro8q7qz1l/kYw58APP9WJMlKauKI9W47/deVx3rCocA3qXlItdDh +BfZFhNemUzWv3JYA9XWVzbnNcyTIqH4HhnQhHFvAgcw+weKR/9TP/vung8Lla1EUvCZZP MYjRNY7wDVpH/oMI5TptnjMslE11Tg5zIUNcfqrXA7Zti8KfvsnzFp3ox9lJ6MrKH4c2hM NmAC0rc8sTkUwg9s8Ex/6lJW9ik5ZCfY8AK9qYDGVZjB7IKIbyeaHJNp0KOIBj01InUQz7 J/mMmobpbqk0ihTka12eXfUnjD96I1kYuJYCvaIKT0iN97g8bPReP5IZWePEvg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618315104; a=rsa-sha256; cv=none; b=oPAFjdLCxebeUG1vlolgKHQw+KBj7nGk0hrL7X1F+YmYE1sRJ1FqPv7esshRMXJESQKwBZ ansjUZvVpiOtCnn/LwKPD6JFvhhPQKpYuxaBTQe4oOSCkXX3r0ikuFmR7Am4zjrOrWHBQN uiO438G0Lc5ZpiXlCSO7PqvcMPFWRadatzho80fAsp2BsrY0VMwa/D71Jlv3V4NXWl0Jrt JHbp3iKlYhPumB2UfEBylNq93lhuvSslLk/cXD+4IzTPhMmlkdZu1RoQZymBpAQS0la5lf 5VF+Id+GLdULgL4UgMuDVoHZqBBIKin28DRorXw8wJeIcHKFgSKC+NK//U+2Gw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=telenet.be header.s=r21 header.b=Kr0BLwd9; dmarc=pass (policy=none) header.from=telenet.be; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -3.24 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=telenet.be header.s=r21 header.b=Kr0BLwd9; dmarc=pass (policy=none) header.from=telenet.be; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: DEDF011650 X-Spam-Score: -3.24 X-Migadu-Scanner: scn0.migadu.com X-TUID: DLI8UDVI1NMz --=-IVRNGQEm+oVXfqEpMf/1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2021-04-13 at 12:01 +0300, Canan Talayhan wrote: > Hi everyone, Welcome! > My name is Canan. I'm an Outreachy applicant. I'm working on the introduc= tory task for > Guix Data Service. Is this =E2=80=98introductory task=E2=80=99 publicly available? If so, cou= ld you post a link? I'm not up-to-date with Outreachy. > Introductory task: > Set a more informative page title for any page where the title is "Guix D= ata Service" >=20 > I've created a patch for the "Jobs" page. If it looks good for everyone t= hen I can proceed with > other applicable pages. >=20 > Now, I'm working on the title part of the code snippet below to make it m= ore elegant. >=20 > ```scm > (define* (layout #:key > (head '()) > (body '()) > title > description) > `((doctype "html") > (html > (@ (lang "en")) > (head > ,@(if title > `((title ,(string-append title " - Guix Data Service"))) Typographical nitpick: I would use a proper dash here (the figure dash =E2= =80=92 or the =E2=80=94 em dash, I always forgot which is correct), instead of the hyphen-minus -. (Resource: ). > `((title "Guix Data Service"))) > ``` You could bring the 'if' inside: `((title ,(if title (string-append title " =E2=80=92 Guix Data Service") "Guix Data Service"))) and a simplification is possible, as adding a title is unconditional: (head (title ,(if title (string-append ...) ...)) ...) > Could you please review and share your comments? I'll be appreciated. >=20 > Attached file: jobs-title-and-view.diff + (define page-header"Jobs") Nitpick: I would put a space before "Jobs"? Also, what's the point of defining this variable, if it is constant? + (define page-header "Job") + (layout + #:title + (string-append page-header job-id) IIRC, job ids are integers, so this would result in titles like "Job1234"? Titles like "Job 1234" would be better. I haven't tested the patch, but better page titles are good, thanks! Maxime. Sometimes reviewing patches, but without actually testing them. Guix IRC: mdevos --=-IVRNGQEm+oVXfqEpMf/1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYHWHPhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7rl9AQDKAaNurf1/I0GKaitxmfSl4B+n 8L/5aFSe5PmuxCZZ6wEAqIIDgp/0RNoRisKDI3KKGi79xhxS5kRVuljChD9OJAc= =7NYe -----END PGP SIGNATURE----- --=-IVRNGQEm+oVXfqEpMf/1--