From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id wAWoHujfDWadcwAAe85BDQ:P1 (envelope-from ) for ; Thu, 04 Apr 2024 01:02:00 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id wAWoHujfDWadcwAAe85BDQ (envelope-from ) for ; Thu, 04 Apr 2024 01:02:00 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1712185320; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TcWbqSXqtey0whotHnMFd4BoHqV1OIH6ZNLQP1V1gZ4=; b=HtJMsRwq9ZOOcb/w4x+9XyKK6f2owBx6klHreEGNPjedNrC2BCSpJbaIkREaoDynb0grp/ LCQCW40zXyzEKAiZmw9bOw1P/4ZXPwLnCr9/SHWwFC/ISQS0OkJSMYPLEKerXmO8a+A2Gt QUvZchBNmfcMknPNe8WVE+iju8LYSnA4UbzgLsZfmX0t9+5H3j36zdsPgpU/cZcDtwk7Rl 6qNZOxw2JPSwtQymsQVrNNUYWDaAjei2yP+QAKva1Nu+reuyBhokjBT5kBP61sWBdBG9bO OhqDSsjJrkEwpG/BJOvlOU3GldW3KYDKfvREdrdUF1OkxW7o3RtZ/hYakZZqUg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1712185320; a=rsa-sha256; cv=none; b=DQhCAlkXU7n/SAHXCLbPxvT25mwQjY8INwWDYJi4OTlRLBligMdLX3kHk7xLsVWm1Cnf0R kggkZBvveF3bPhnvE1wSScslvaYDEBrLdAajI+LozQDqhKfhCIvHZotfOWsPl/lunQe4pu Ms/mxekwDKP7z8XVQdkCw6zoRDKm3as7S92JDQE/sMmlPwvA+dkSeO03inlLISGgzjXgaz mJeQDr+eTuQ7EfucTPXfz1KAzBiIUEAa5R5vhN19pLzy1ysjlEaGPCawxSPEF0X/L7Ltve 6gBAPMhwdORzs/gV7TyYdRkxnBUEPRXMoZbYBxFoiEPEl+pJVV9SDothiAIhlQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 55D3638375 for ; Thu, 04 Apr 2024 01:02:00 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rs9bk-00076S-23; Wed, 03 Apr 2024 19:01:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rs9bc-00075l-P7 for guix-devel@gnu.org; Wed, 03 Apr 2024 19:01:20 -0400 Received: from vmi993448.contaboserver.net ([194.163.141.236] helo=mutix.org) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rs9ba-0002Yu-Q3 for guix-devel@gnu.org; Wed, 03 Apr 2024 19:01:20 -0400 Received: from [192.168.1.172] (host81-147-82-218.range81-147.btcentralplus.com [81.147.82.218]) (Authenticated sender: cdo) by mutix.org (Postfix) with ESMTPSA id 81FE0A63403; Thu, 4 Apr 2024 01:01:16 +0200 (CEST) Message-ID: Date: Thu, 4 Apr 2024 00:01:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: Coordinators for patch review session on Tuesday Content-Language: en-US From: Christina O'Donnell To: guix-devel Cc: efraim@flashner.co.il, Steve George References: <55f9be63-419e-57ba-7bd8-691cf80ab012@mutix.org> In-Reply-To: <55f9be63-419e-57ba-7bd8-691cf80ab012@mutix.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=194.163.141.236; envelope-from=cdo@mutix.org; helo=mutix.org X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.802, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.36 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -6.36 X-Migadu-Queue-Id: 55D3638375 X-TUID: fpCm7nS9ycOE Hi, This is just to say that I went to review [2], but ended up making the changes myself, so I've submitted modified patches for those packages. Hopefully they're of a quality that's worth pushing. I'm going to be busy this weekend, but I'll see if I get time to do some reviewing later on. It's actually quite fun! Kind regards, Christina [2] https://debbugs.gnu.org/cgi-bin/bugreport.cgi?users=guix;bug=56576 On 03/04/2024 12:00, Christina O'Donnell wrote: > Hi Steve, > > On 02/04/2024 21:23, Steve George wrote: >> Hi Christina - thanks for coming along today - I hope it was useful. > > Yes I did find it helpful. Since I'm the least experienced out of > everyone there, I just stayed quiet and tried to absorb as much as I > could. > > It was good to see that not everyone was using Emacs, and I'm going to > try to start using Efraim's vi script for GTAGS in Guile. > >> There's good instructions on the Wiki on how to review patches: >> >> https://libreplanet.org/wiki?title=Group:Guix/PatchReviewSessions2024 >> >> I would love feedback on how to improve them! >> >> There's plenty of patches to review, I've been keeping a list of them >> for the patch review calls: >> >> https://debbugs.gnu.org/cgi-bin/pkgreport.cgi?tag=patch-review-hackers-list;users=guix >> >> >> And the wiki page references some other reports. >> >> Please pick some patches and have a go - if you want someone else to >> look at them feel free to ping here or on IRC! > > Thank you for writing this up in so much depth! I've reviewed [1] and > tried to tag it as reviewed-looks-good, though I don't think that has > gone through. If you or someone else could take a look at it then I'd > appreciate that. I plan on reviewing some more patches this evening. > > Kind regards, > Christina > > [1] https://debbugs.gnu.org/cgi-bin/bugreport.cgi?users=guix;bug=65938