From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id uLWnFwBawWU+KAAAe85BDQ:P1 (envelope-from ) for ; Mon, 05 Feb 2024 22:58:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id uLWnFwBawWU+KAAAe85BDQ (envelope-from ) for ; Mon, 05 Feb 2024 22:58:24 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707170304; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:autocrypt:autocrypt; bh=YjZRU5yykfzSvjtlc3YQLjuKPVP5wP9nkjQe2xAGKEw=; b=VKWKkvvF/qZYV2pzAW4GRDjfdEV5GIeE7zfkhWgjhl3HzcIJKMctFAbjfM0nnG7qVh2Dmy HhoPjHHDFW5vckgXUJhtU3bwUkd9gwwXOLPFVWy7F2gKnuBK7Cyee4SI8GwlqZ8+H1uoJK q0jB313bny6bsjF4JARMge2qU6AW0ebSRWN6a1nRD6e3MqYgJRqkkU14xBT03EX6F6vddQ kk9GvpggR+SyOiASrdVuvpAdC8AlUVAjTkR/pbs54c/QgL/147QQ9NBhxIFl0RQBieh3Ty 3hBYz4QnMqAbBWyS3xGuvznaSAqqrmkUT1vn6GtCpybd2rR6CfmZk51MTqlx9A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707170304; a=rsa-sha256; cv=none; b=GQ/A1sATHhLrDpPGpqHFqI/jPUVZAyH7nJGHdJuHyRrFD03jOSqB1zuIrKZj6Fj7jNdMAz SVJt2M4k/xiD67YCRDwDzIo04kCOhehTGdeP1tNCeqsz9zhaOtWxXSQ8KAczjuY+i8Xomv 7oOKoRdsIZEW4o+53GE36KAKF9pNA4BTDlZhMV9b2c0NzlgEXC11UVMbzPD4U0PFRNKrw5 aQMZiVQLAtW5zsDw2c5f/idboEcjFxfeqxaxCl/jfQnlA6+nzI5jiEtqZEzNlvQpEDXGHo NZl22YDnpUKmc3nIe7OUEaoco2e43wP3EnOih4zVHQhd2BgDlv4SdbZQljPb3w== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 31D8E5BE46 for ; Mon, 5 Feb 2024 22:58:24 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rX6yC-00032s-7H; Mon, 05 Feb 2024 16:57:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rX6y9-00032S-4S for guix-devel@gnu.org; Mon, 05 Feb 2024 16:57:37 -0500 Received: from mailtransmit05.runbox.com ([2a0c:5a00:149::26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rX6y7-0004aS-7o for guix-devel@gnu.org; Mon, 05 Feb 2024 16:57:36 -0500 Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com) by mailtransmit05.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1rX6y2-00CHGE-AJ for guix-devel@gnu.org; Mon, 05 Feb 2024 22:57:30 +0100 Received: from [10.9.9.73] (helo=submission02.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1rX6y0-00067v-1z; Mon, 05 Feb 2024 22:57:29 +0100 Received: by submission02.runbox with esmtpsa [Authenticated ID (641962)] (TLS1.2:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.93) id 1rX6xp-00Gn5N-Vv; Mon, 05 Feb 2024 22:57:18 +0100 Message-ID: Date: Mon, 5 Feb 2024 21:57:10 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Guix Days: Patch flow discussion To: Leo Famulari , guix-devel@gnu.org References: <10c82db7-6fc6-4fa0-8213-e207fa54db58@futurile.net> <646ed226-7002-49b5-84c9-4f4be2425636@app.fastmail.com> From: Steve George Content-Language: en-US Autocrypt: addr=steve@futurile.net; keydata= xsDiBEeOGAkRBADbe+7yuHsSTTf+qTgHRwHhJDGQNyQttd9xZibSv5fYRn8ZlOxFMxbZT+7A g8iDI+baRQ3P3zRDbt3my4gNnKSsIzAbJOguG2V3L5Ffwpl6O9fADO9QskQMUIZlmCn9p1+7 8wR32shpydC0EXn/QIArV9A7Zb8q95QvM2BC1bn/FwCg4g01xZ3RNrl8DweLJiz06G1HzAsE AJsvg+pzB3afZdnh+e/iFiu+L4eupyy4bqPGzDKd64p36AkD+WcXOEDrefsGeaB2vzpiLtmk x0WOPJWPHz4e7oHR/FgR2RVqXllqb+X0Kz0OQ9IEPMot6VF05CJDM730Ucesby+/98BlzkFP qRkzgHlg6wcDgP9+SyaVAnqtvPT0A/4tSwMx4yfjmTxZPNBm46slfoZ30pXb5Sby8jt2e1A6 TDEqqdcOmUi6y+e0gZUhWZM/ADu5LCYXM1V+ZlYckhti95kjlqhhqYXGhgluUZgLPhkcLq7H G0oIxfhnIVaCRJkOp3qwxsmjOCuQ6TzBc1fQlPGwqsjWjVMLN+BXE/SN/s0hU3RldmUgR2Vv cmdlIDxzdGV2ZUBmdXR1cmlsZS5uZXQ+wmMEExECACMFAlV+JpkCGwMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDVKaVaaC5nXEo3AJ94jDsx5bgupvindS7gYgP4pMlfRgCZAYbY CF9DA/Ls6q7c4CaIEfR4bSHOwU0ER44YIRAIAOsIe0DcvPCVm5hI8I0GuudtNlGZYv3f7lI/ vqrvxi29iA+E2Uhlo0YSJcNsfHJW/knn+ssDhXDXzBYpHLYQsn20OGBAWJ3kmCvZUrPFzsmX 4c58p7pnYS2W74kcfV7yNrs/We/zGDJfxgniVyX6dbxi6V9Rs3DTocAvvpFzPUcKydV2jYL8 /igKIIvblbtTKhXMpT4or8cPk/FJUjfiqNDrGliCSAYuuqA4s9+wvHGa8uJGPITH53UIuYtG NZnSGyiI4TyqSj3jmngMKwRs4miZlJRf2gjgOfUBmmSfZ1FN5ujoyK7OyLdi53xqiZ0SytWX 0n02mZA66rSL5uDklJMAAwYIAOQuUYZAf+b67vxUTuacljbY34Liu1QxSib8fPSWFyGAbViQ g/VdRa0F7zC2DHJSyMT257O/gfg3Y5QDr5Hj6YennJ6BoC9V7Cds2kj2av+DZJsUFG6D9Olx mXZTwerbNElnqPgG182dwzWRxi0p8ly5lDLvL9YUO8cTLB1WnOuonAt2zZAJNjApji+s2hNz mqVIjXNXgUpSwrXjMat+pDQ4p2fkK1CStrwHgX5JU0r7E1f7R8nZtNLrCRaoaPrCawb3pa9K okP9nvhNnwbRHW4TflvUyBu7+d4TXBOqQlj6XMB8cSi4OqUzAagrbhR/MW4IstJzfEAEQZEu K8TiSGHCSQQYEQIACQUCR44YIQIbDAAKCRDVKaVaaC5nXDhCAKCPLzJRlndFTe4coYPLCjsL PAfWbwCg2otwkKTWVAqr9ASWl/XUWZprHII= In-Reply-To: <646ed226-7002-49b5-84c9-4f4be2425636@app.fastmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: permerror client-ip=2a0c:5a00:149::26; envelope-from=steve@futurile.net; helo=mailtransmit05.runbox.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.76 X-Migadu-Queue-Id: 31D8E5BE46 X-Spam-Score: -6.76 X-Migadu-Scanner: mx11.migadu.com X-TUID: bt0BXxAu+QUT Hi Leo, On 05/02/2024 14:07, Leo Famulari wrote: > On Mon, Feb 5, 2024, at 04:39, Steve George wrote: >> Our goal for the discussion: >> >> How do we double the number of patches that are *reviewed* and >> *applied* to Guix in the next six months? >> >> Patch flow is a pipeline, to change it we could: >> >> a. Increase the number of committers - more people to do the >> work >> b. Increase the efficiency of existing committers >> c. Open the gates by decreasing the quality expected from patches > > Hi George, Just 'Steve' :-) > It's an important subject and, in my opinion, more important than any technical questions at this stage of the project. > > However, I think the question assumes that all contributions should be accepted, and that the entire problem is that we are not accepting them efficiently enough. We should not unconsciously accept this assumption. > > Guix can reject contributions, either in a general way (we don't want that type of thing in Guix), or due to specific reasons (the code is not idiomatic, the contributor can't work effectively with the rest of the group, etc). (...) Today there are 1264 bugs with patches attached to them today [0]. We don't have any stats (that I'm aware of) that show how many patches the project reviews and either asks for edits, rejects or applies. The group - and I hope the minutes reflect this - wanted to maintain the current standards. So the discussion of the pipeline focused on how we review more patches, and make decisions about them: whether that decision is to accept the contribution, ask for more work, or reject it as out of scope. To answer your comment about the 'unconscious' assumptions - my personal view is: * I don't think ALL patches should simply be accepted * I do think that more patches need to be reviewed and a decision made * I believe (no evidence) the project is missing out on great contributions amongst those 1200+ patches in the tracker * I believe (no evidence) that potential contributors are put-off by the speed of review / lack of clarity Thanks, Steve [0] https://debbugs.gnu.org/rrd/guix-patches.html