* [PATCH 1/1] gnu: twolame: Fix test failure with Perl 5.24.
@ 2016-10-24 5:53 Leo Famulari
2016-10-24 7:46 ` Hartmut Goebel
2016-10-24 20:21 ` Leo Famulari
0 siblings, 2 replies; 3+ messages in thread
From: Leo Famulari @ 2016-10-24 5:53 UTC (permalink / raw)
To: guix-devel
* gnu/packages/audio.scm (twolame)[source]: Add snippet to fix test.
---
gnu/packages/audio.scm | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index db32b6f..5a2cf09 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2134,7 +2134,14 @@ conversion. It may be used, for example, to resample PCM-encoded audio.")
(uri (string-append "mirror://sourceforge/twolame/twolame/" version
"/twolame-" version ".tar.gz"))
(sha256
- (base32 "0ahiqqng5pidwhj1wzph4vxxgxxgcfa3gl0gywipzx2ii7s35wwq"))))
+ (base32 "0ahiqqng5pidwhj1wzph4vxxgxxgcfa3gl0gywipzx2ii7s35wwq"))
+ (modules '((guix build utils)))
+ ;; The tests break with Perl 5.24:
+ ;; https://github.com/njh/twolame/issues/21
+ (snippet
+ '(begin
+ (substitute* "tests/test.pl" (("\\(@_\\)") "($_[0])"))
+ #t))))
(build-system gnu-build-system)
(inputs
`(("libsndfile" ,libsndfile)))
--
2.10.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] gnu: twolame: Fix test failure with Perl 5.24.
2016-10-24 5:53 [PATCH 1/1] gnu: twolame: Fix test failure with Perl 5.24 Leo Famulari
@ 2016-10-24 7:46 ` Hartmut Goebel
2016-10-24 20:21 ` Leo Famulari
1 sibling, 0 replies; 3+ messages in thread
From: Hartmut Goebel @ 2016-10-24 7:46 UTC (permalink / raw)
To: guix-devel
Am 24.10.2016 um 07:53 schrieb Leo Famulari:
> + ;; The tests break with Perl 5.24:
> + ;; https://github.com/njh/twolame/issues/21
> + (snippet
> + '(begin
> + (substitute* "tests/test.pl" (("\\(@_\\)") "($_[0])"))
> + #t))))
I'm curious: Are we really removing the tests from the sources "just"
because they are failing?
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] gnu: twolame: Fix test failure with Perl 5.24.
2016-10-24 5:53 [PATCH 1/1] gnu: twolame: Fix test failure with Perl 5.24 Leo Famulari
2016-10-24 7:46 ` Hartmut Goebel
@ 2016-10-24 20:21 ` Leo Famulari
1 sibling, 0 replies; 3+ messages in thread
From: Leo Famulari @ 2016-10-24 20:21 UTC (permalink / raw)
To: guix-devel
On Mon, Oct 24, 2016 at 01:53:36AM -0400, Leo Famulari wrote:
> * gnu/packages/audio.scm (twolame)[source]: Add snippet to fix test.
The fix was merged upstream...
https://github.com/njh/twolame/commit/eba1e286f10e5ce15a08bd9fd556779ce9cce98b
... so I pushed this patch to core-updates.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-24 20:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-24 5:53 [PATCH 1/1] gnu: twolame: Fix test failure with Perl 5.24 Leo Famulari
2016-10-24 7:46 ` Hartmut Goebel
2016-10-24 20:21 ` Leo Famulari
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).