From mboxrd@z Thu Jan  1 00:00:00 1970
From: julien lepiller <julien@lepiller.eu>
Subject: Re: [PATCH 10/96] gnu: Add ocamlmod.
Date: Wed, 04 Jan 2017 17:57:49 +0100
Message-ID: <e0ade02013531b4aaa221e7dea99b15b@lepiller.eu>
References: <20170103191217.6431-1-julien@lepiller.eu>
	<20170103191217.6431-11-julien@lepiller.eu>
	<CAL1_imntgjSAumNKEHzGd+txRZDAR=fJ+ECkko1Y+u1P=GdJQA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48862)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <julien@lepiller.eu>) id 1cOot6-0008PZ-Dx
	for guix-devel@gnu.org; Wed, 04 Jan 2017 11:58:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <julien@lepiller.eu>) id 1cOot1-0007T5-Ih
	for guix-devel@gnu.org; Wed, 04 Jan 2017 11:58:08 -0500
Received: from dau94-h03-89-91-205-84.dsl.sta.abo.bbox.fr
	([89.91.205.84]:38240 helo=skaro.lepiller.eu)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <julien@lepiller.eu>) id 1cOot1-0007O2-63
	for guix-devel@gnu.org; Wed, 04 Jan 2017 11:58:03 -0500
Received: from localhost (localhost [127.0.0.1])
	by skaro.lepiller.eu (Postfix) with ESMTP id 50B497FD4D
	for <guix-devel@gnu.org>; Wed,  4 Jan 2017 17:57:58 +0100 (CET)
Received: from skaro.lepiller.eu ([127.0.0.1])
	by localhost (lepiller.eu [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id MtjTUQLy4T4S for <guix-devel@gnu.org>;
	Wed,  4 Jan 2017 17:57:50 +0100 (CET)
Received: from webmail.lepiller.eu (localhost [127.0.0.1])
	by skaro.lepiller.eu (Postfix) with ESMTPA id 506297FAA9
	for <guix-devel@gnu.org>; Wed,  4 Jan 2017 17:57:50 +0100 (CET)
In-Reply-To: <CAL1_imntgjSAumNKEHzGd+txRZDAR=fJ+ECkko1Y+u1P=GdJQA@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org

Le 2017-01-04 16:00, David Craven a =C3=A9crit=C2=A0:
> +    (arguments `(#:phases (modify-phases %standard-phases (delete=20
> 'check))))
>=20
> The standard way of doing this is with #:tests? #f.

The thing is tests are passed during 'build. This is activated by the=20
--enable-tests argument, that is enabled by #:tests? #t. This is only to=20
disable passing tests twice. With #:tests? #f, no test is run. So, what=20
should we do? Maybe change ocaml-build-system to have #:tests? only=20
modify the phases, and not the configure argument, and having a=20
separated #:test-argument? to add the argument to configure?