From: "José Miguel Sánchez García" <jmi2k@openmailbox.org>
To: David Craven <david@craven.ch>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add nim.
Date: Mon, 09 Jan 2017 18:21:26 +0100 [thread overview]
Message-ID: <e0610f3cc95d5a617601667952606d6a@openmailbox.org> (raw)
In-Reply-To: <CAL1_imkxD3LXFyzDtV3_YmgPNWTAS8SYs3zBXxz_uWH9Sd7T+g@mail.gmail.com>
On 2017-01-09 18:09, David Craven wrote:
> Hi Jose,
>
> Some changes I made:
>
> * change module name to (gnu packages nim).
> * reorder imports alphabetically.
> * added you to the copyright header.
> * added a comment as to why the tests are disabled.
> * returned true after substitute*
> * used (zero? (system* "./install.sh" ...
> * removed new line after description
> * added a trailing dot to the commit message headline
>
> I don't think we need a separate /opt subfolder, opt is basically
> /gnu/store for FHS systems.
>
> Pushed as 84aafbbb664925ed1a9de3e53238bc54c743a968. Thank you!
--------------------------------------------------------------------------------
Thanks for cleaning *the stupid mess* I made with this particular
package. Sorry
for that, I'll start to calm down and check my patches before
submitting.
--
José Miguel Sánchez García
next prev parent reply other threads:[~2017-01-09 17:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 16:27 [PATCH] gnu: Add nim José Miguel Sánchez García
2017-01-07 0:37 ` José Miguel Sánchez García
2017-01-07 16:41 ` José Miguel Sánchez García
2017-01-07 23:50 ` José Miguel Sánchez García
2017-01-08 13:47 ` David Craven
2017-01-09 16:23 ` José Miguel Sánchez García
2017-01-09 17:09 ` David Craven
2017-01-09 17:21 ` José Miguel Sánchez García [this message]
2017-01-09 17:37 ` David Craven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0610f3cc95d5a617601667952606d6a@openmailbox.org \
--to=jmi2k@openmailbox.org \
--cc=david@craven.ch \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).