unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: guix-devel@gnu.org
Subject: Re: [PATCH 8/8] gnu: python-dulwich: Fix tests.
Date: Wed, 18 Jan 2017 00:38:48 +0100	[thread overview]
Message-ID: <e05db5f2-d574-1b24-8387-4edc030cac86@crazy-compilers.com> (raw)
In-Reply-To: <20170117222548.13995-9-dannym@scratchpost.org>

Am 17.01.2017 um 23:25 schrieb Danny Milosavljevic:
> +             ;(substitute* "dulwich/hooks.py"
> +             ;  (("f[.]write[(]args[[]0[]][)]") "f.write(args[0].encode('utf-8'))"))

This is an interesting but quite unusual way to escape the special
characters. I suggest using the more common type with back-slash, esp.
since "[[]" and "[]]" are very hard to get.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

  parent reply	other threads:[~2017-01-17 23:38 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <gu878tqpjw93.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
2017-01-17 22:25 ` [PATCH 0/8] Make python-oslosphinx work in python-tests branch Danny Milosavljevic
2017-01-17 22:25   ` [PATCH 1/8] gnu: python-oslosphinx: Update to 4.9.0 Danny Milosavljevic
2017-01-17 22:25   ` [PATCH 2/8] gnu: Add python-reno Danny Milosavljevic
2017-01-17 22:36     ` Marius Bakke
2017-01-17 23:42     ` Hartmut Goebel
2017-01-17 22:25   ` [PATCH 3/8] gnu: python-requests: Update to 2.10.0 Danny Milosavljevic
2017-01-17 22:38     ` Marius Bakke
2017-01-17 23:03       ` Danny Milosavljevic
2017-01-17 22:25   ` [PATCH 4/8] gnu: Add python-dulwich Danny Milosavljevic
2017-01-17 22:43     ` Marius Bakke
2017-01-17 22:25   ` [PATCH 5/8] gnu: Add python-geventhttpclient Danny Milosavljevic
2017-01-17 22:48     ` Marius Bakke
2017-01-17 23:12       ` Danny Milosavljevic
2017-01-17 23:23         ` Marius Bakke
2017-01-17 22:25   ` [PATCH 6/8] gnu: Add python-fastimport Danny Milosavljevic
2017-01-17 22:50     ` Marius Bakke
2017-01-17 22:25   ` [PATCH 7/8] gnu: python-oslosphinx: Add python-reno Danny Milosavljevic
2017-01-17 22:51     ` Marius Bakke
2017-01-17 22:25   ` [PATCH 8/8] gnu: python-dulwich: Fix tests Danny Milosavljevic
2017-01-17 22:55     ` Marius Bakke
2017-01-17 22:58       ` Danny Milosavljevic
2017-01-17 23:38     ` Hartmut Goebel [this message]
2017-01-17 22:31   ` [PATCH 0/8] Make python-oslosphinx work in python-tests branch Marius Bakke
2017-01-17 22:46     ` Danny Milosavljevic
2017-01-17 22:56     ` Danny Milosavljevic
2017-01-17 23:17       ` Marius Bakke
2017-01-17 23:28         ` Danny Milosavljevic
2017-01-17 23:46           ` Danny Milosavljevic
2017-01-18  0:18             ` Danny Milosavljevic
2017-01-18  0:07           ` Marius Bakke
2017-01-18  0:32   ` ng0
2017-01-19  9:48     ` Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e05db5f2-d574-1b24-8387-4edc030cac86@crazy-compilers.com \
    --to=h.goebel@crazy-compilers.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).