From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ADd0O90Ds2OX6QAAbAwnHQ (envelope-from ) for ; Mon, 02 Jan 2023 17:18:38 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6OyGOt0Ds2PgMwAAG6o9tA (envelope-from ) for ; Mon, 02 Jan 2023 17:18:37 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6734CC97E for ; Mon, 2 Jan 2023 17:18:37 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCNW0-0007sl-6q; Mon, 02 Jan 2023 11:18:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCNVl-0007sI-FI for guix-devel@gnu.org; Mon, 02 Jan 2023 11:18:05 -0500 Received: from mout.kundenserver.de ([212.227.126.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCNVi-0007o5-Fs for guix-devel@gnu.org; Mon, 02 Jan 2023 11:18:04 -0500 Received: from hermia.goebel-consult.de ([87.176.140.105]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MJEAV-1pVQUr1TvH-00KfaV; Mon, 02 Jan 2023 17:17:54 +0100 Received: from [192.168.110.2] (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 8E2EF62032; Mon, 2 Jan 2023 17:18:02 +0100 (CET) Content-Type: multipart/mixed; boundary="------------w2GZ6KrZONCj5D473uqrreBJ" Message-ID: Date: Mon, 2 Jan 2023 17:17:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Ricardo Wurmus Cc: guix-devel@gnu.org References: <874jtb7icl.fsf@elephly.net> <875ydp5ctv.fsf@elephly.net> <871qod5b4v.fsf@elephly.net> Content-Language: de-DE, en-US From: Hartmut Goebel Organization: crazy-compilers.com Subject: Re: All updaters are broken In-Reply-To: <871qod5b4v.fsf@elephly.net> X-Provags-ID: V03:K1:IghwKYUT4rddf9LAl14j9PUCxOqj+P2MP7lZb6tSxO9UlEw0AQF EknuVAzqZ4+MxuTMF2KBCB7y+cAffZ0i2zq1N0h87ac5n+K+qNz8CNUv+q1URiMYdMl5sb9 GxNeQnnqa8lh7zpSQCjF81dzyYAORaHaOewOYisC01enQtEmH1TeY7s4sgNSKrm/WZYRhFC 23lUhsDGkqCvlhoGx55Sw== UI-OutboundReport: notjunk:1;M01:P0:TkoPsmZbK7s=;210E4whm86adWLg94NW1Eqg7gOE GuwzfwI1fM7U61x49AInFXwAje6jwN6slNp4AYY0iEHPWSE4vUMfPW6Brxq+1mkKV/VaCYoyu t609gJwcatYO5y/49p0/OFu69fBQNdgs4Ow8CKKuSMYywGEljH4lxHj+ScsLj5xHAO5qYBwpK uFTWQ4GA37z2JB292fSaoM1NoaV6vuOYfI1U1P80/bFCANLWXJ5/jW5JYxzYpKxexDkdg7P/+ 3PyC/AQCSVA2lrBtazn4GMQcyzODgaL7krPzNJzQ6J6BwuuZvHnQ/OisfQsYNVdJErizGNpEP 413HwXAms4EF1yzxwNJkHD59b+6HVcsuwY9SPhG8zY3PX51ASjl6hfCFAh8+GH7273Rc4RqAY XH7ekyOnt/2D7wO0c9+5mZpJQqgMYoPPe+w9WaOEf9TIhXzIo4vxS3Rbh52oJM60GWT/wC9K8 wEwCAppzkMAWvgKfnrx7D4zntRZqiCCh+iNkjtuV1o93HrK/rPIq+Z70iIyU4w1wJBi/nebuK SAoPVmwyuA7ZuvHgzYnVEkfXO0YjDMYI5dyWZQ6dVWHYzviVNj12JVhBUBNwOX97v+2ifjby4 fEQTDHmdfRYvQ8EtmoTtXZ5qlBOTtLAT1OGTtw3dl/ZIdyZWbaVJVxX5Yu/r5eknKpoWkQV1o Xnqn2uvGA1+gUYRQUdPwShRmZMSc4kqehRZWohrijw== Received-SPF: pass client-ip=212.227.126.130; envelope-from=h.goebel@crazy-compilers.com; helo=mout.kundenserver.de X-Spam_score_int: -49 X-Spam_score: -5.0 X-Spam_bar: ----- X-Spam_report: (-5.0 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-3.142, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672676317; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=AgPDLPnaO13PXrT178DnKJdgkKyNK0daCj87NpiQMxQ=; b=N8934JpfxWpGklK6QghiOVhq7d5dw8SseR8y75HFtCUaHKUSnWxBchjKAmtkeL7sX8KgoG jcBpzy6mrXuo56IvG60/OPLUxtKeDh19352wnzlP3UN9MGZfSx8n2EeJxegHywSC8wWNaB /s4jMJqvEd2RtLOjOVhTGb25jqp5q35h5tCQ7oE8lRvhikgYB1O94FyX5di4tQwNicGEKq 5Ki0xfgO8zxEVVIOme2ssgeZhNd78OEOrc8pYEYmZ5PxaEaF9XBxnSWt4v3XuDhxk6LuW1 88X76+PZLrJ5qZYYWOJxjN3Lk4b+t+VQ0ZxpumDxUj4e6TDX6VFTA0oYCJAcwA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1672676317; a=rsa-sha256; cv=none; b=NZiuIeaoUi3u12jAp0YOJZ0Tm62rSnRZMPSC9E96jcmYloun/+J+66HQe/gTmllqv/gNOY 3aj2xCKeqvPW0fz04KOLd+fUCgwq5+pU4fmQJ564z5ZcYczI7aPFXWpQl4oF1K1dJbs5it MeLCDPa/w3Phu2O05vuySAtUk89QZMVof65mvCwTTBPGtRpWnrS5nO9jtyf0BC6Mef/Vr8 6rZ8K9PUb/uyTRJ9vIt6rsq90qVvyArX13O0RvThiB9W5R+fYG0RemFq+DLF+r4BxRtHDX f9g1RojaVM+fJlUxMwBkqgSd47jWqrLKQa5ghmKU0a7eWaPoLJjo/P5rEVAvsg== X-Spam-Score: -1.65 X-Migadu-Queue-Id: 6734CC97E Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -1.65 X-TUID: 0KaPgLxGazwT This is a multi-part message in MIME format. --------------w2GZ6KrZONCj5D473uqrreBJ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello Ricardo, Am 02.01.23 um 14:16 schrieb Ricardo Wurmus: > Attached is a crude implementation of that. I just consed the lists > together instead of returning multiple values, because the compound > value is to be used inside the store monad where we can’t easily access > multiple values. Thanks for providing the patch. For me this looks huge and hard to maintain. I'd rather make "options->update-specs" return update-specs in any cases. This adds a small overhead only in the case of --recursive. Enclosed please find my proposal. WDY? Tested cases ./pre-inst-env guix refresh --list-updaters ./pre-inst-env guix refresh -u python-flask ./pre-inst-env guix refresh -u python-flask=2.2.1 ./pre-inst-env guix refresh python-flask ./pre-inst-env guix refresh python-flask=2.2.1 ./pre-inst-env guix refresh --list-transitive python-flask ./pre-inst-env guix refresh --list-dependent python-flask ./pre-inst-env guix refresh -l python-flask ./pre-inst-env guix refresh -t hexpm -u ./pre-inst-env guix refresh -t hexpm ./pre-inst-env guix refresh -t hexpm erlang-relx -u ./pre-inst-env guix refresh -t hexpm erlang-relx ./pre-inst-env guix refresh -e '(@ (gnu packages erlang) erlang-relx)' ./pre-inst-env guix refresh -m test-manifest.scm ./pre-inst-env guix refresh --recursive python-flask ./pre-inst-env guix refresh --select=core -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | --------------w2GZ6KrZONCj5D473uqrreBJ Content-Type: text/x-patch; charset=UTF-8; name="refresh.diff" Content-Disposition: attachment; filename="refresh.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2d1aXgvc2NyaXB0cy9yZWZyZXNoLnNjbSBiL2d1aXgvc2NyaXB0cy9y ZWZyZXNoLnNjbQppbmRleCBlMGI5NGNlNDhkLi5mOWM0YTRjODdjIDEwMDY0NAotLS0gYS9n dWl4L3NjcmlwdHMvcmVmcmVzaC5zY20KKysrIGIvZ3VpeC9zY3JpcHRzL3JlZnJlc2guc2Nt CkBAIC0xODQsOCArMTg0LDggQEAgc3BlY2lmaWVkIHdpdGggYC0tc2VsZWN0Jy5cbiIpKQog ICAoc2hvdy1idWctcmVwb3J0LWluZm9ybWF0aW9uKSkKIAogKGRlZmluZSAob3B0aW9ucy0+ dXBkYXRlLXNwZWNzIG9wdHMpCi0gICJSZXR1cm4gdGhlIGxpc3Qgb2YgcGFja2FnZXMgcmVx dWVzdGVkIGJ5IE9QVFMsIGhvbm9yaW5nIG9wdGlvbnMgbGlrZQotJy0tcmVjdXJzaXZlJy4i CisgICJSZXR1cm4gdGhlIGxpc3Qgb2YgPHVwZGF0ZS1zcGVjPiByZWNvcmRzIHJlcXVlc3Rl ZCBieSBPUFRTLCBob25vcmluZworb3B0aW9ucyBsaWtlICctLXJlY3Vyc2l2ZScuIgogICAo ZGVmaW5lIGNvcmUtcGFja2FnZT8KICAgICAobGV0KiAoKGlucHV0LT5wYWNrYWdlIChtYXRj aC1sYW1iZGEKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKChuYW1lICg/IHBhY2th Z2U/IHBhY2thZ2UpIF8gLi4uKSBwYWNrYWdlKQpAQCAtMjIwLDE1ICsyMjAsMTUgQEAgdXBk YXRlIHdvdWxkIHRyaWdnZXIgYSBjb21wbGV0ZSByZWJ1aWxkLiIKICAgICAgICAgKF8KICAg ICAgICAgIChjb25zIHBhY2thZ2UgbHN0KSkpKSkKIAotICAoZGVmaW5lIGFyZ3MtcGFja2Fn ZXMKLSAgICA7OyBQYWNrYWdlcyBleHBsaWNpdGx5IHBhc3NlZCBhcyBjb21tYW5kLWxpbmUg YXJndW1lbnRzLgorICAoZGVmaW5lIGFyZ3MtcGFja2FnZXMtPnVwZGF0ZS1zcGVjcworICAg IDs7IHVwZGF0ZS1zcGVjcyBmb3IgcGFja2FnZXMgZXhwbGljaXRseSBwYXNzZWQgYXMgY29t bWFuZC1saW5lIGFyZ3VtZW50cy4KICAgICAobWF0Y2ggKGZpbHRlci1tYXAgKG1hdGNoLWxh bWJkYQogICAgICAgICAgICAgICAgICAgICAgICAgICgoJ2FyZ3VtZW50IC4gc3BlYykKICAg ICAgICAgICAgICAgICAgICAgICAgICAgOzsgVGFrZSBlaXRoZXIgdGhlIHNwZWNpZmllZCB2 ZXJzaW9uIG9yIHRoZQogICAgICAgICAgICAgICAgICAgICAgICAgICA7OyBsYXRlc3Qgb25l LgogICAgICAgICAgICAgICAgICAgICAgICAgICAodXBkYXRlLXNwZWNpZmljYXRpb24tPnVw ZGF0ZS1zcGVjIHNwZWMpKQogICAgICAgICAgICAgICAgICAgICAgICAgICgoJ2V4cHJlc3Np b24gLiBleHApCi0gICAgICAgICAgICAgICAgICAgICAgICAgIChyZWFkL2V2YWwtcGFja2Fn ZS1leHByZXNzaW9uIGV4cCkpCisgICAgICAgICAgICAgICAgICAgICAgICAgIChwYWNrYWdl LT51cGRhdGUtc3BlYyAocmVhZC9ldmFsLXBhY2thZ2UtZXhwcmVzc2lvbiBleHApKSkKICAg ICAgICAgICAgICAgICAgICAgICAgICAoXyAjZikpCiAgICAgICAgICAgICAgICAgICAgICAg IG9wdHMpCiAgICAgICAoKCkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIDtkZWZhdWx0IHRvIGFsbCBwYWNrYWdlcwpAQCAtMjM2LDI1ICsyMzYsMjkgQEAgdXBk YXRlIHdvdWxkIHRyaWdnZXIgYSBjb21wbGV0ZSByZWJ1aWxkLiIKICAgICAgICAgICAgICAg ICAgICAgICAgICgnY29yZSBjb3JlLXBhY2thZ2U/KQogICAgICAgICAgICAgICAgICAgICAg ICAgKCdub24tY29yZSAobmVnYXRlIGNvcmUtcGFja2FnZT8pKQogICAgICAgICAgICAgICAg ICAgICAgICAgKF8gKGNvbnN0ICN0KSkpKSkKLSAgICAgICAgIChmb2xkLXBhY2thZ2VzIChs YW1iZGEgKHBhY2thZ2UgcmVzdWx0KQotICAgICAgICAgICAgICAgICAgICAgICAgICAoaWYg KHNlbGVjdD8gcGFja2FnZSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChrZWVw LW5ld2VzdCBwYWNrYWdlIHJlc3VsdCkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHJlc3VsdCkpCi0gICAgICAgICAgICAgICAgICAgICAgICAnKCkpKSkKKyAgICAgICAgICht YXAgcGFja2FnZS0+dXBkYXRlLXNwZWMKKyAgICAgICAgICAgICAgKGZvbGQtcGFja2FnZXMg KGxhbWJkYSAocGFja2FnZSByZXN1bHQpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKGlmIChzZWxlY3Q/IHBhY2thZ2UpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChrZWVwLW5ld2VzdCBwYWNrYWdlIHJlc3VsdCkKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgcmVzdWx0KSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgJygpKSkpKQogICAgICAgKHNvbWUgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICA7dXNlci1zcGVjaWZpZWQgcGFja2FnZXMKICAgICAgICBzb21lKSkpCiAKLSAg KGRlZmluZSBwYWNrYWdlcworICAoZGVmaW5lIHVwZGF0ZS1zcGVjcwogICAgIChtYXRjaCAo YXNzb2MtcmVmIG9wdHMgJ21hbmlmZXN0KQotICAgICAgKCNmIGFyZ3MtcGFja2FnZXMpCi0g ICAgICAoKD8gc3RyaW5nPyBmaWxlKSAocGFja2FnZXMtZnJvbS1tYW5pZmVzdCBmaWxlKSkp KQorICAgICAgKCNmIGFyZ3MtcGFja2FnZXMtPnVwZGF0ZS1zcGVjcykKKyAgICAgICgoPyBz dHJpbmc/IGZpbGUpIChtYXAgcGFja2FnZS0+dXBkYXRlLXNwZWMKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKHBhY2thZ2VzLWZyb20tbWFuaWZlc3QgZmlsZSkpKSkpCiAKICAg KGlmIChhc3NvYy1yZWYgb3B0cyAncmVjdXJzaXZlPykKICAgICAgIChtbGV0ICVzdG9yZS1t b25hZCAoKGVkZ2VzIChub2RlLWVkZ2VzICViYWctbm9kZS10eXBlCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYWxsLXBhY2thZ2VzKSkpKQotICAg ICAgICAocmV0dXJuIChub2RlLXRyYW5zaXRpdmUtZWRnZXMgcGFja2FnZXMgZWRnZXMpKSkK KyAgICAgICAgKHJldHVybiAobWFwIHBhY2thZ2UtPnVwZGF0ZS1zcGVjCisgICAgICAgICAg ICAgICAgICAgICAobm9kZS10cmFuc2l0aXZlLWVkZ2VzIChtYXAgdXBkYXRlLXNwZWMtcGFj a2FnZSB1cGRhdGUtc3BlY3MpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGVkZ2VzKSkpKQogICAgICAgKHdpdGgtbW9uYWQgJXN0b3JlLW1vbmFkCi0g ICAgICAgIChyZXR1cm4gcGFja2FnZXMpKSkpCisgICAgICAgIChyZXR1cm4gdXBkYXRlLXNw ZWNzKSkpKQogCiAMCiA7OzsKQEAgLTI2OCwxMyArMjcyLDE3IEBAIHVwZGF0ZSB3b3VsZCB0 cmlnZ2VyIGEgY29tcGxldGUgcmVidWlsZC4iCiAgICh2ZXJzaW9uIHVwZGF0ZS1zcGVjLXZl cnNpb24pKQogCiAoZGVmaW5lICh1cGRhdGUtc3BlY2lmaWNhdGlvbi0+dXBkYXRlLXNwZWMg c3BlYykKLSAgIkdpdmVuIFNQRUMsIGEgcGFja2FnZSBuYW1lIGxpa2UgXCJndWlsZUAyLjA9 Mi4wLjhcIiwgcmV0dXJuIGEgPHVwZGF0ZT4KKyAgIkdpdmVuIFNQRUMsIGEgcGFja2FnZSBu YW1lIGxpa2UgXCJndWlsZUAyLjA9Mi4wLjhcIiwgcmV0dXJuIGEgPHVwZGF0ZS1zcGVjPgog cmVjb3JkIHdpdGggdHdvIGZpZWxkczogdGhlIHBhY2thZ2UgdG8gdXBncmFkZSwgYW5kIHRo ZSB0YXJnZXQgdmVyc2lvbi4iCiAgIChtYXRjaCAoc3RyaW5nLXJpbmRleCBzcGVjICNcPSkK ICAgICAoI2YgICh1cGRhdGUtc3BlYyAoc3BlY2lmaWNhdGlvbi0+cGFja2FnZSBzcGVjKSAj ZikpCiAgICAgKGlkeCAodXBkYXRlLXNwZWMgKHNwZWNpZmljYXRpb24tPnBhY2thZ2UgKHN1 YnN0cmluZyBzcGVjIDAgaWR4KSkKICAgICAgICAgICAgICAgICAgICAgICAoc3Vic3RyaW5n IHNwZWMgKDErIGlkeCkpKSkpKQogCisoZGVmaW5lIChwYWNrYWdlLT51cGRhdGUtc3BlYyBw YWNrYWdlKQorICAiR2l2ZW4gUEFDS0FHRSByZXR1cm4gYW4gPHVwZGF0ZS1zcGVjPiByZWNv cmQuIgorICAodXBkYXRlLXNwZWMgcGFja2FnZSAjZikpCisKIAwKIDs7OwogOzs7IFVwZGF0 ZXMuCg== --------------w2GZ6KrZONCj5D473uqrreBJ--