From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Geerinckx-Rice Subject: Re: Addition to gnu-build-system: make test. Date: Sun, 28 Aug 2016 14:37:35 +0200 Message-ID: References: <87inunse1q.fsf@we.make.ritual.n0.is> <20160828090544.GE26988@macbook42.flashner.co.il> <20160828094103.GA25813@jocasta.intra> <87a8fxkw78.fsf@we.make.ritual.n0.is> <20160828122353.GA27216@jocasta.intra> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="UqoT8mq7aOM1Gk0lXlgKMt7ll6KahpM4b" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdzLP-0003iA-HW for guix-devel@gnu.org; Sun, 28 Aug 2016 08:37:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdzLM-0004eT-CV for guix-devel@gnu.org; Sun, 28 Aug 2016 08:37:47 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:60275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdzLM-0004eJ-4p for guix-devel@gnu.org; Sun, 28 Aug 2016 08:37:44 -0400 In-Reply-To: <20160828122353.GA27216@jocasta.intra> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: john@darrington.wattle.id.au, ng0@n0.is Cc: guix-devel@gnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UqoT8mq7aOM1Gk0lXlgKMt7ll6KahpM4b Content-Type: multipart/mixed; boundary="B9spXeDLrGjD0atTPOpv2d1WeWH5sRaM6" From: Tobias Geerinckx-Rice To: john@darrington.wattle.id.au, ng0@n0.is Cc: guix-devel@gnu.org Message-ID: Subject: Re: Addition to gnu-build-system: make test. References: <87inunse1q.fsf@we.make.ritual.n0.is> <20160828090544.GE26988@macbook42.flashner.co.il> <20160828094103.GA25813@jocasta.intra> <87a8fxkw78.fsf@we.make.ritual.n0.is> <20160828122353.GA27216@jocasta.intra> In-Reply-To: <20160828122353.GA27216@jocasta.intra> --B9spXeDLrGjD0atTPOpv2d1WeWH5sRaM6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hullo, On 28/08/16 14:23, John Darrington wrote: > Why not generalise that: > check-alias "test" which defaults to check. Or something similar. Sure. How about #:test-target? :-) (Not that calling it test-target instead of check-target isn't needlessly confusing already. Trips me up every time.) > "make check" is what the Gnu Coding Standards specify: > http://www.gnu.org/prep/standards/standards.html#Standard-Targets > > So I think it should stay as it is - at least for the gnu-build-system I agree. I don't see how adding dark magic here will save packagers' time. We'll still have to check the logs to make sure tests actually run, and any new failure modes are just that little bit harder to debug. Kind regards, T G-R (back from an IMAP holiday) --B9spXeDLrGjD0atTPOpv2d1WeWH5sRaM6-- --UqoT8mq7aOM1Gk0lXlgKMt7ll6KahpM4b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCgAGBQJXwtsPAAoJEJHM25tIVBuZZPEIAL9AL7NUGk+g9iyBpeuL4Q9P sy2H0DU8R88UAjqGcSFfhGDsrbTKZo6MQQ6NSWnVC0r43YrsjHwRAEyKbgbeGjSy MB9k0BrlRfA0NQL6W6EPoLrbM6tbD2dztI9mgOnFrYGKjTNGvZ/9EqEBSq9jxYxM rKpF7wGr+vDkvn8BCzXDOtkMBBshAwtJF7LIbouF+drmPnrdyTxNbIVtYq1SbY2N u+ny0gt69Bvb5MbJvG8iduuc5vxZDtayvAA0UZ3qyhMiZuiGaJwI3arYeS19VQVG GVHRk8anKDxByaO2ApGRUWy7LD6RNX81dtWSEjOPfX1Bk4LJPuvUSedCXsSeVS0= =7vq0 -----END PGP SIGNATURE----- --UqoT8mq7aOM1Gk0lXlgKMt7ll6KahpM4b--