* Questions on updating `aerc` and its Go dependency
@ 2025-02-05 8:05 Tanguy LE CARROUR
2025-02-05 10:31 ` Leo Famulari
0 siblings, 1 reply; 3+ messages in thread
From: Tanguy LE CARROUR @ 2025-02-05 8:05 UTC (permalink / raw)
To: guix-devel
Hi Guix,
I’m working on updating `aerc` to 0.20.1. On the package itself I:
- bumped the version
- removed the patch
- fixed the way the `notmuch` flaged is passed
but I also had to update one of its dependency: `go-git-sr-ht-rjarry-go-opt`.
It’s a major update to `2.0.1` so I created a new `go-git-sr-ht-rjarry-go-opt-v2`
inheriting from `go-git-sr-ht-rjarry-go-opt`… but realized that
`go-git-sr-ht-rjarry-go-opt` was only used by `aerc`.
Is it any use to create a new package? Should I just update the existing one?
Should I rename it? Create a new one? … so many questions!! 😱
Any advice welcome!
--
Tanguy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Questions on updating `aerc` and its Go dependency
2025-02-05 8:05 Questions on updating `aerc` and its Go dependency Tanguy LE CARROUR
@ 2025-02-05 10:31 ` Leo Famulari
2025-02-06 8:35 ` tanguy
0 siblings, 1 reply; 3+ messages in thread
From: Leo Famulari @ 2025-02-05 10:31 UTC (permalink / raw)
To: Tanguy LE CARROUR, guix-devel
On Wed, Feb 5, 2025, at 03:05, Tanguy LE CARROUR wrote:
> but I also had to update one of its dependency:
> `go-git-sr-ht-rjarry-go-opt`.
> It’s a major update to `2.0.1` so I created a new
> `go-git-sr-ht-rjarry-go-opt-v2`
> inheriting from `go-git-sr-ht-rjarry-go-opt`… but realized that
> `go-git-sr-ht-rjarry-go-opt` was only used by `aerc`.
>
> Is it any use to create a new package? Should I just update the existing one?
> Should I rename it? Create a new one? … so many questions!! 😱
You should update the existing package. No need to rename it.
Treat it like any other library package. It would be more complicated if it had more than one user.
Any other questions? :)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Questions on updating `aerc` and its Go dependency
2025-02-05 10:31 ` Leo Famulari
@ 2025-02-06 8:35 ` tanguy
0 siblings, 0 replies; 3+ messages in thread
From: tanguy @ 2025-02-06 8:35 UTC (permalink / raw)
To: Leo Famulari; +Cc: sharlatanus, guix-devel
Hi Leo,
On Wed Feb 5, 2025 at 11:31 AM CET, Leo Famulari wrote:
> On Wed, Feb 5, 2025, at 03:05, Tanguy LE CARROUR wrote:
>> but I also had to update one of its dependency:
>> `go-git-sr-ht-rjarry-go-opt`.
>> It’s a major update to `2.0.1` so I created a new
>> `go-git-sr-ht-rjarry-go-opt-v2`
>> inheriting from `go-git-sr-ht-rjarry-go-opt`… but realized that
>> `go-git-sr-ht-rjarry-go-opt` was only used by `aerc`.
>>
>> Is it any use to create a new package? Should I just update the existing one?
>> Should I rename it? Create a new one? … so many questions!! 😱
>
> You should update the existing package. No need to rename it.
>
> Treat it like any other library package. It would be more complicated if it had more than one user.
That makes total sense to me! Thanks! But…
> Any other questions? :)
Yes! 😁
But Oleg made a comment that also make total sense:
> Yes it has V2 in import path
> https://git.sr.ht/~rjarry/go-opt/tree/main/item/go.mod#L1
>
> So the common logic is to inherit and create new package variant.
> gnu packages golang-* contains a lot of examples of that, feel free
> to take look.
> […]
> The package variable name should follow go.mod import path,
> the first line of that file.
And the module is definitively name `git.sr.ht/~rjarry/go-opt/v2`.
So now I would, update and rename.
WDYT?
--
Tanguy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-06 8:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-05 8:05 Questions on updating `aerc` and its Go dependency Tanguy LE CARROUR
2025-02-05 10:31 ` Leo Famulari
2025-02-06 8:35 ` tanguy
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).