From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id IMvECUubZma3HAAAe85BDQ:P1 (envelope-from ) for ; Mon, 10 Jun 2024 06:20:59 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id IMvECUubZma3HAAAe85BDQ (envelope-from ) for ; Mon, 10 Jun 2024 08:20:59 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jlUTnugU; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718000459; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=sx0hHjUy+8wVEuNHiN9IX4rLHznjp5Ewnty54hdUz+U=; b=JZ1hCdHnFp8tNA9Y155WLafNGTomsh3+MJ0lHxlTmHcXYImifiEpi2wIRwKaUvoj8CTSew yWo+3wanZLH9poM5aY0ycv8ia3NSqZ47+Gm7kC5JgJjR8o48nZ+UYzXcGflgvHsYsw3Kjc Kv+l5hs7ANGopcErkZhrncvdrVSr+bn9CEJzi3WMHSfDTv8eneOZdFNn4wL7o/iexVkt9x be9+grzQm4HEx7ihcs/Ks0G1b3fLUMvZOKKM486wi4yNee4GMLHixdTdMLkDVx2/QnzhCS ALr05Y7gmnEd4Cdh19MVmjnO6T0Y8NK1HGEmVukSq5Tncoz8gQXAFD93aBe6YQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jlUTnugU; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718000459; a=rsa-sha256; cv=none; b=dp2niBi5UOrJSpagrSQAmEsmZwv9uL5hvK/feZSPyRPZQu1U/BRGA92FHW6RaOq1nDbUMH Tcz4gGMtMOoibugh4YMIgfi8xyi/z2fy2KlqpdR92pjeZm4yXC72J4lcepLy7OWgDxC7t7 0lUjm6KoKKIOSGKuh9wyQgqL2w64GTb9JGMIukwLvDRKh1vQqGcs3WnHB8r6DSnB412csz 5+zelHlrf8ftSpqUpu43pSgNGSGJl8vt3KBSWT7nc4DL9UzDcGd/anr+1viDGKVy0t/4aj +uhE9eFQaKFtpZ8CRAtB/yUyQE1oU1gqOh/3bQIusYVKv5IlNXCuPy9J1Xqryw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0638138E81 for ; Mon, 10 Jun 2024 08:20:59 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGYOJ-0001p5-08; Mon, 10 Jun 2024 02:20:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGYOE-0001of-Ps for guix-devel@gnu.org; Mon, 10 Jun 2024 02:20:24 -0400 Received: from mail-oo1-xc2e.google.com ([2607:f8b0:4864:20::c2e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGYOB-00045B-Nl; Mon, 10 Jun 2024 02:20:22 -0400 Received: by mail-oo1-xc2e.google.com with SMTP id 006d021491bc7-5b9706c84e5so2296857eaf.1; Sun, 09 Jun 2024 23:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718000416; x=1718605216; darn=gnu.org; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=sx0hHjUy+8wVEuNHiN9IX4rLHznjp5Ewnty54hdUz+U=; b=jlUTnugUW1BCPMVa5DYIRP++Gu608DiZ8RHzBgrGPIsQSS0ZAxgj2cEueZQGi5lgmI 3gFqN6HXV7QUmLdBlUpDEPVbFBhWbyUsg2J2WJyHr8AZQD13ku2mpA7FulB9zyQp1lUb 0JIX/hv6/l8Rr6dvPZ/gj6drwR6n9gF8UVZg1bi9HpSjsDOG3MbJpjs5Grvb+72GG4Y6 Dp5cr60LHco5Fe9PsU3U7909UP9fjyukKJamhCPsn78nTOCfKPdZy+DxXYY7/++Bswah 0Rw8TkXaZg3hhn/1sejW7zcpe4aw/twzNBqu/ie4R2l8GA3yQfgu/zBe/INSDJPOTSNK 9uSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718000416; x=1718605216; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sx0hHjUy+8wVEuNHiN9IX4rLHznjp5Ewnty54hdUz+U=; b=GSOt+VEGP3whG6uvwMiR2f0/MbH0LcrBmOycg64YsxUPr0fZDFVa6pzEQEK3tdfo6f 18cUq8zmHueD8zo8wyJ9dGlXqelUj2epzybQ7krUIa9h+CnP+uh2TtAfaauugfKZsPis EXylakUlI7tqu8w6naXbzmAVZXNhS62pgtyy7cIZ/fwurou50N2avlWjLciHx7+YL64K TNlA0i64mrDnMTnHpJ2R+mSCB0I0TKeqU9LJK3CPnGHRCe7ezjOmNNTpxzhh3Wlnr5eN A/uSNRohFLcyChp6yi69nnDTT5y+QobhFUhNmDmK54b5hnUwPhOP4JmF7NfISQiqLMY1 kaZw== X-Gm-Message-State: AOJu0YyNhYbx1ERJ3RUothNd+v4YNBMqL+d5kVme6jSQVPb5yCWtQH9d lLtpWzeQqkL1pNVHn+0PN+12R61ExbCXUq05r6YKQT+bEM4DQ0TZ9Teesg== X-Google-Smtp-Source: AGHT+IG32JZiSOmIQGA5kqpmgBsUlCoFJv+ZBAHMXst56hNJgASEhLk3owSMjG6sRgCHN+GMVkrCcw== X-Received: by 2002:a05:6358:2829:b0:19f:1365:77b8 with SMTP id e5c5f4694b2df-19f1ff8efe4mr1096487455d.23.1718000416243; Sun, 09 Jun 2024 23:20:16 -0700 (PDT) Received: from [10.143.113.222] ([130.95.40.103]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6ec124e0b64sm1508108a12.69.2024.06.09.23.20.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Jun 2024 23:20:15 -0700 (PDT) Message-ID: Date: Mon, 10 Jun 2024 06:20:10 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: en-US To: Guix Devel Cc: =?UTF-8?Q?Ludovic_Court=c3=a8s?= From: Ada Stevenson Subject: Disabling authentication checks for tests in local Guix checkouts Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::c2e; envelope-from=adanskana@gmail.com; helo=mail-oo1-xc2e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.67 X-Spam-Score: -9.67 X-Migadu-Queue-Id: 0638138E81 X-Migadu-Scanner: mx13.migadu.com X-TUID: rdmwhah1aPds Hi Guix, I'm currently trying to help test the changes to GRUB submitted in issue #71348[1]. Unfortunately, `make check`, whilst building the local Guix channel, authenticates every commit. That means commits not signed by people in `guix-authorizations` will stop the channel from building and prevents running any of the tests. I have tried to fix the issue by writing a patch: ----- diff --git a/etc/system-tests.scm b/etc/system-tests.scm index 221a63bb7f..6655850396 100644 --- a/etc/system-tests.scm +++ b/etc/system-tests.scm @@ -49,7 +49,7 @@ (define (tests-for-current-guix source commit) ;; of tests to run in the usual way: ;; ;; make check-system TESTS=installed-os - (let ((guix (channel-source->package source #:commit commit))) + (let ((guix (channel-source->package source #:commit commit #:authenticate? #f))) (map (lambda (test) (system-test (inherit test) diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm index 54521ab3c4..46d66604c7 100644 --- a/gnu/packages/package-management.scm +++ b/gnu/packages/package-management.scm @@ -563,7 +563,7 @@ (define-public guix the Nix package manager.") (license license:gpl3+)))) -(define* (channel-source->package source #:key commit) +(define* (channel-source->package source #:key commit (authenticate? #t)) "Return a package for the given channel SOURCE, a lowerable object." (package (inherit guix) @@ -571,7 +571,8 @@ (define* (channel-source->package source #:key commit) (if commit (string-take commit 7) ""))) (build-system channel-build-system) (arguments `(#:source ,source - #:commit ,commit)) + #:commit ,commit + #:authenticate? ,authenticate?)) (inputs '()) (native-inputs '()) (propagated-inputs '()))) ----- Initially this seems like it works, as it starts to index all of the commits in the local checkout, which didn't occur beforehand, instead immediately giving a `Git error: cannot locate remote-tracking branch 'origin/keyring'` (I've run `git fetch -a`, and my Savannah remote is called `origin`). I'm not sure where this second building of the channel is occurring; the channel-build-system is being passed the `authenticate? #f` flag, so I'm at a loss. I'd really appreciate any input or help! Warmly, Ada [1] https://issues.guix.gnu.org/issue/71348