From: Ada Stevenson <adanskana@gmail.com>
To: Guix Devel <guix-devel@gnu.org>
Cc: "Ludovic Courtès" <ludo@gnu.org>
Subject: Disabling authentication checks for tests in local Guix checkouts
Date: Mon, 10 Jun 2024 06:20:10 +0000 [thread overview]
Message-ID: <d4a6746a-1ea7-d272-e29b-ce75bcb9cf9e@gmail.com> (raw)
Hi Guix,
I'm currently trying to help test the changes to GRUB submitted in issue
#71348[1]. Unfortunately, `make check`, whilst building the local Guix
channel, authenticates every commit. That means commits not signed by
people in `guix-authorizations` will stop the channel from building and
prevents running any of the tests.
I have tried to fix the issue by writing a patch:
-----
diff --git a/etc/system-tests.scm b/etc/system-tests.scm
index 221a63bb7f..6655850396 100644
--- a/etc/system-tests.scm
+++ b/etc/system-tests.scm
@@ -49,7 +49,7 @@ (define (tests-for-current-guix source commit)
;; of tests to run in the usual way:
;;
;; make check-system TESTS=installed-os
- (let ((guix (channel-source->package source #:commit commit)))
+ (let ((guix (channel-source->package source #:commit commit
#:authenticate? #f)))
(map (lambda (test)
(system-test
(inherit test)
diff --git a/gnu/packages/package-management.scm
b/gnu/packages/package-management.scm
index 54521ab3c4..46d66604c7 100644
--- a/gnu/packages/package-management.scm
+++ b/gnu/packages/package-management.scm
@@ -563,7 +563,7 @@ (define-public guix
the Nix package manager.")
(license license:gpl3+))))
-(define* (channel-source->package source #:key commit)
+(define* (channel-source->package source #:key commit (authenticate? #t))
"Return a package for the given channel SOURCE, a lowerable object."
(package
(inherit guix)
@@ -571,7 +571,8 @@ (define* (channel-source->package source #:key commit)
(if commit (string-take commit 7) "")))
(build-system channel-build-system)
(arguments `(#:source ,source
- #:commit ,commit))
+ #:commit ,commit
+ #:authenticate? ,authenticate?))
(inputs '())
(native-inputs '())
(propagated-inputs '())))
-----
Initially this seems like it works, as it starts to index all of the
commits in the local checkout, which didn't occur beforehand, instead
immediately giving a `Git error: cannot locate remote-tracking branch
'origin/keyring'` (I've run `git fetch -a`, and my Savannah remote is
called `origin`).
I'm not sure where this second building of the channel is occurring; the
channel-build-system is being passed the `authenticate? #f` flag, so I'm
at a loss.
I'd really appreciate any input or help!
Warmly,
Ada
[1] https://issues.guix.gnu.org/issue/71348
next reply other threads:[~2024-06-10 6:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 6:20 Ada Stevenson [this message]
2024-06-17 13:05 ` Disabling authentication checks for tests in local Guix checkouts Ludovic Courtès
2024-06-17 14:02 ` Suhail Singh
2024-06-17 21:52 ` Ludovic Courtès
2024-06-18 2:36 ` Suhail Singh
2024-06-18 8:25 ` Ada Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4a6746a-1ea7-d272-e29b-ce75bcb9cf9e@gmail.com \
--to=adanskana@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).