unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Andreas Enge <andreas@enge.fr>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: v2: A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches.
Date: Mon, 5 Sep 2022 15:03:34 +0200	[thread overview]
Message-ID: <d44ff54e-6e24-c90e-9a6a-770bf5c1f8e0@telenet.be> (raw)
In-Reply-To: <YvGFS8SF13ppuDWL@jurong>


[-- Attachment #1.1.1.1: Type: text/plain, Size: 1847 bytes --]


On 08-08-2022 23:51, Andreas Enge wrote:
>> 20.4.5.3 Fixing technical issues (compilation errors, test failures, other bugs
>> ...)
>> Usually, a bug fix comes in the form of a patch copied from upstream or another
>> distribution. In that case, simply adding the patch to the 'patches' field is
>> the most convenient and usually does not cause any problems; there is no need
>> to rewrite it as a snippet or a phase.
>> If no ready-made patch already exists, then choosing between a patch or a
>> snippet is a matter of convenience. However, there are two things to keep in
>> mind:
>> First, when the fix is not Guix-specific, it is strongly desired to upstream
>> the fix to avoid the additional maintenance cost to Guix. As upstreams cannot
>> accept a snippet, writing a patch can be a more efficient use of time.
>> Secondly, if the fix of a technical issue embeds a store file name, then it has
>> to be a phase. Otherwise, if a store file name was embedded in the source, the
>> result of 'guix build --source' would be unusable on non-Guix systems and
>> likely also unusable on Guix systems of another architecture.
> Do you mean "phase" here instead of "snippet"? That is what I usually do...
> My practice is to use a patch when the goal is to eventually change the
> source code upstream (or it is already changed upstream and we can take a
> patch from their git repo, say), and a phase when one cannot expect upstream
> to incorporate the changes since they are specific to Guix (like embedding
> store paths, as Liliana writes, where apparently a phase is the only option
> anyway).

I meant 'snippet' in this subsubsection. Bugfixes seem useful to have in 
the result of "guix build --source", and appear to be required to be in 
there for the 'corresponding source' thing.

Greetings,
Maxime.


[-- Attachment #1.1.1.2: Type: text/html, Size: 2301 bytes --]

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

  parent reply	other threads:[~2022-09-05 14:00 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-25  3:17 A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches Maxime Devos
2022-07-25  5:21 ` Julien Lepiller
2022-07-25 11:18   ` Maxime Devos
2022-07-25 11:37     ` Julien Lepiller
2022-08-04  8:51 ` Ludovic Courtès
2022-08-05  3:23 ` Philip McGrath
2022-08-05  8:13   ` Maxime Devos
2022-08-05  3:38 ` Philip McGrath
2022-08-05  8:09   ` Maxime Devos
2022-08-05 10:18 ` Maxime Devos
2022-08-05 13:59 ` v2: " Maxime Devos
2022-08-06  6:55   ` [PATCH] doc: Update contribution guidelines on patches, etc Liliana Marie Prikler
2022-08-06  6:55     ` [PATCH v2] " Liliana Marie Prikler
2022-09-02 13:12       ` Ludovic Courtès
2022-09-02 18:05         ` Maxime Devos
2022-09-05  9:47           ` Ludovic Courtès
2022-09-05 13:12             ` Maxime Devos
2022-09-05 16:05               ` Maxime Devos
2022-08-09 16:45     ` [PATCH] " Maxime Devos
2022-08-09 17:05       ` Liliana Marie Prikler
2022-08-09 18:19         ` Maxime Devos
2022-08-09 19:08           ` Liliana Marie Prikler
2022-08-09 20:30             ` Maxime Devos
2022-08-10  4:25               ` Liliana Marie Prikler
2022-08-09 20:40             ` Maxime Devos
2022-08-08 21:51   ` v2: A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches Andreas Enge
2022-08-09 15:06     ` Maxime Devos
2022-08-09 17:10       ` Andreas Enge
2022-09-05 13:03     ` Maxime Devos [this message]
2022-09-07 12:17       ` Andreas Enge
2022-09-07 18:08         ` Maxime Devos
2022-08-09 18:58   ` david larsson
2022-08-09 20:53     ` Maxime Devos
2022-08-10 11:23       ` david larsson
2022-08-05 16:59 ` blake
2022-08-09 16:30   ` Maxime Devos
2022-09-05 14:06     ` Maxime Devos
2022-08-10  6:10   ` blake
2022-08-10  9:06     ` Maxime Devos
2022-08-10 10:33     ` blake
2022-08-10 10:44       ` Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d44ff54e-6e24-c90e-9a6a-770bf5c1f8e0@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).