From: Maxime Devos <maximedevos@telenet.be>
To: "Xinglu Chen" <public@yoctocell.xyz>, "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org, Maxim Cournoyer <maxim.cournoyer@gmail.com>,
Andrew Tropin <andrew@trop.in>
Subject: Re: Code sharing between system and home services (was Re: On the naming of System and Home services modules.)
Date: Fri, 24 Sep 2021 16:03:09 +0200 [thread overview]
Message-ID: <d135b1da2df9d253fa1ca3e3b56bdc893df0e80b.camel@telenet.be> (raw)
In-Reply-To: <87tuiajdv1.fsf@yoctocell.xyz>
[-- Attachment #1: Type: text/plain, Size: 3615 bytes --]
Xinglu Chen schreef op vr 24-09-2021 om 15:35 [+0200]:
> On Thu, Sep 23 2021, Ludovic Courtès wrote:
>
> > Hi,
> >
> > Xinglu Chen <public@yoctocell.xyz> skribis:
> >
> > > Some services might be useful to have in both Guix System and Guix Home;
> > > for instance, Guix System currently has a service for configuring
> > > Syncthing, and I think it makes sense to also have one for Guix Home,
> > > this would mean that people not using Guix System (me :-)) could also
> > > have Guix manage Syncthing. With the current approach, we would have to
> > > copy and paste quite a bit of code, and if the Syncthing service for
> > > Guix System changes, then the one for Guix Home might have to change as
> > > well.
> >
> > Silly question, but why do we need to have two different configuration
> > record types in the first place?
>
> The problem is that the configuration records for system and home
> service don’t necessarily have the same fields. The Syncthing service
> for Guix System has a ‘user’ and a ‘group’ field, which is not really of
> any use in Guix Home, as the only user would be the user invoking ‘guix
> home’.
>
> > Sharing configuration between Home and System sounds important to me: it
> > means users can easily move services from one to the other, which is
> > pretty big deal. It also means we’d have much less code to maintain.
>
> Agreed, that’s what I would like to see as well.
>
> > Would that be feasible? (Apologies if this has already been
> > discussed!)
>
> Since it might not make sense to have the same records fields for a
> system service and home service, I proposed (in the mail you replied to)
> a ‘define-configuration’ form that would generate a configuration record
> for a system service and optionally one for a home service, without
> having to maintain two records separately.
>
> --8<---------------cut here---------------start------------->8---
> (define-configuration syncthing-configuration
> (package
> (package syncthing)
> "Syncthing package to use.")
> (arguments
> (list-of-strings ’())
> "Command line arguments to pass to the Syncthing package.")
> (log-flags
> (integer 0)
> "Sum of logging flags.")
> (user
> (maybe-string 'disabled)
> "The user as which the Syncthing service is to be run."
> (home-service? #f)) ; not for Guix Home
> (group
> (string "users")
> "The group as which the Syncthing service is to be run."
> (home-service? #f)) ; likewise ^^
> (home
> (maybe-string 'disabled)
> "Common configuration and data directory.")
> (home-service? #t))
> --8<---------------cut here---------------end--------------->8---
>
> It would generate <syncthing-configuration> and
> <home-syncthing-configuration>. The only difference being that
> <home-syncthing-configuration> doesn’t have a ‘user’ and a ‘group’
> field.
The 'parent' mechanism (rnrs records syntactic) 'parent' could be used
here (after adapting it to define-configuration), to define three record types:
The record type with all fields common to the home configuration and system configuration
(<common-syncthing-configuration> + common-syncthing-configuration?)
and the record types for the home and system configuration
(<syncthing-configuration> + syncthing-configuration? and <home-syncthing-configuration>
+ home-syncthing-configuration?).
Using this mechanism, all syncthing-configuration? and home-syncthing-configuration?
are common-syncthing-configuration?.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-09-24 14:03 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 8:47 On the naming of System and Home services modules Andrew Tropin
2021-09-15 10:09 ` Maxime Devos
2021-09-15 13:15 ` Andrew Tropin
2021-09-15 13:06 ` Xinglu Chen
2021-09-15 14:50 ` Katherine Cox-Buday
2021-09-16 10:01 ` Andrew Tropin
2021-09-16 9:57 ` Andrew Tropin
2021-09-17 9:28 ` Xinglu Chen
2021-09-17 11:35 ` Andrew Tropin
2021-09-19 14:54 ` Xinglu Chen
2021-09-23 20:08 ` Ludovic Courtès
2021-09-24 8:08 ` Andrew Tropin
2021-09-28 12:17 ` Ludovic Courtès
2021-09-24 13:35 ` Code sharing between system and home services (was Re: On the naming of System and Home services modules.) Xinglu Chen
2021-09-24 14:03 ` Maxime Devos [this message]
2021-09-24 15:39 ` Xinglu Chen
2021-09-24 17:02 ` Maxime Devos
2021-09-28 12:19 ` Ludovic Courtès
2021-09-28 6:03 ` Andrew Tropin
2021-09-24 15:32 ` Joshua Branson
2021-09-28 12:21 ` Ludovic Courtès
2021-09-29 13:52 ` Maxime Devos
2021-10-02 14:27 ` Ludovic Courtès
2021-10-02 22:13 ` Code sharing between system and home services Vagrant Cascadian
2021-10-04 14:34 ` Ludovic Courtès
2021-10-03 8:45 ` Code sharing between system and home services (was Re: On the naming of System and Home services modules.) Maxime Devos
2021-10-04 14:32 ` Ludovic Courtès
2021-10-04 16:14 ` Maxime Devos
2021-10-06 13:12 ` Ludovic Courtès
2021-09-28 2:32 ` Maxim Cournoyer
2021-09-16 3:05 ` On the naming of System and Home services modules Ryan Prior
2021-09-16 8:50 ` Andrew Tropin
2021-09-17 13:43 ` pinoaffe
2021-09-23 20:10 ` Ludovic Courtès
2021-09-28 6:32 ` Andrew Tropin
2021-09-28 12:26 ` Ludovic Courtès
2021-09-28 13:48 ` Andrew Tropin
2021-09-28 19:36 ` Oleg Pykhalov
2021-10-02 14:22 ` Ludovic Courtès
2021-10-02 17:23 ` Oleg Pykhalov
2021-09-28 15:25 ` Xinglu Chen
2021-10-02 14:25 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d135b1da2df9d253fa1ca3e3b56bdc893df0e80b.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=andrew@trop.in \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=maxim.cournoyer@gmail.com \
--cc=public@yoctocell.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).