From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id SLncA9GF/2RVTgAAauVa8A:P1 (envelope-from ) for ; Mon, 11 Sep 2023 23:25:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id SLncA9GF/2RVTgAAauVa8A (envelope-from ) for ; Mon, 11 Sep 2023 23:25:37 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6A1BF52EF3 for ; Mon, 11 Sep 2023 23:25:31 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=riseup.net header.s=squak header.b="h/Mq1bJG"; dmarc=pass (policy=none) header.from=riseup.net; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694467531; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=Erx1gF2okqexYF8St+Cm8FCj+Yhxd874Fh0pyE/6AAE=; b=nLqTRnJ1RN5I64+cpmF6WffOH7jxZDgaxofe5lp/mtho09aW0F2CE9eKmzcnEy6PYDsm4R moUmKQyX+epxhRbOK6AxKTUrC/YFYoYgYqOkZrq0zWUUP+jWIbxJV85DpnmzPby3+501Uw 9h7+HC4ONuAVsjvfkpHZADwbRQfk6Lw2SCUestBTyiDeYjT6XHQ1xooPXtERFz/co9vOov POgjW+W/Mb4x/c6QUGG1O0GMhH3OcUmmckgLs3urWCEAssNrXVscRd0U4dq79y95BajWyj QkF9EPbDIc7WysBxPFkFdKWBD0qm62p2+TPupzkL/fd+qvbQbbBp8+cmNsWbyQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694467531; a=rsa-sha256; cv=none; b=DLPPnbup/bm9Vu7kmAsl0lrz8ictV6LZcMaAuoRkH6H+F7Z1EzSyUNLOh8HW1mVSAWA8fh mMdUkRTxt7KBg9wQD2Xd/njEonxW6kEnAgvrQm3hK8CoohjdCWu9B3eii1qRwuCHQZZenF e7kwLkBmcE5xJnl0Hd5yAg3xQB6s18aj/1W5j1MAogYTt13BOovc2Cy6Bq8/cs5huYqYdu zHtOWyEs2scqPPZVn+9avYPNVh5kOteb4vQNB9SbsiPxrsyxGUFfjU2iceQbGCKmFR1BL8 ZMR+r1KGsxeS7FpU/Sxt7glOh2gC5jFENBkMxzxfaF6t5dktZcoTwHOMY54dAg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=riseup.net header.s=squak header.b="h/Mq1bJG"; dmarc=pass (policy=none) header.from=riseup.net; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfoOz-0008QX-BQ; Mon, 11 Sep 2023 17:25:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfoOw-0008Q4-Rz for guix-devel@gnu.org; Mon, 11 Sep 2023 17:24:59 -0400 Received: from mx1.riseup.net ([198.252.153.129]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfoOt-0007aF-Aw; Mon, 11 Sep 2023 17:24:57 -0400 Received: from fews02-sea.riseup.net (fews02-sea-pn.riseup.net [10.0.1.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx1.riseup.net (Postfix) with ESMTPS id 4Rl09J0MzZzDrJr; Mon, 11 Sep 2023 21:24:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1694467492; bh=F+ZdJ+NJETTaVMLmNhd8Gfz9aC3giHpT2RO9TvxYODs=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=h/Mq1bJGT1juHqWJ4cCfut8BGGOZiUoWlPRdJ6w2nq1lNPmYtIhH1rCs7ngGda3iV 5maSQ7nJDu1cuc2i/SKSF22nlxRaZ0KJ41OEGNf1ZQXsPngfZEdb332LVwKiXvIxgn fSK9+iZ3+TLjSJcweZFWucB4xoRdm8+8jA5YYNDc= X-Riseup-User-ID: B05FFFEF224F735062C2A482BBC49D3C6A523D49AB767B5DE413DFC415923AF1 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews02-sea.riseup.net (Postfix) with ESMTPSA id 4Rl09H28mPzFrx1; Mon, 11 Sep 2023 21:24:51 +0000 (UTC) References: <871qf4ivsr.fsf@gmail.com> <874jk0jyf2.fsf@wireframe> From: Csepp To: Vagrant Cascadian Cc: Simon Tournier , Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s?= , guix-devel@gnu.org Subject: Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts) Date: Mon, 11 Sep 2023 23:23:09 +0200 In-reply-to: <874jk0jyf2.fsf@wireframe> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=198.252.153.129; envelope-from=raingloom@riseup.net; helo=mx1.riseup.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.84 X-Spam-Score: -9.84 X-Migadu-Queue-Id: 6A1BF52EF3 X-Migadu-Scanner: mx0.migadu.com X-TUID: ft8C68rjfhOE Vagrant Cascadian writes: > [[PGP Signed Part:Undecided]] > On 2023-09-11, Simon Tournier wrote: >> On Mon, 11 Sep 2023 at 16:23, Ludovic Court=C3=A8s wrote: >>> Note that the patch series adds a hard dependency on Git. >>> This is because the existing =E2=80=98git-fetch=E2=80=99 code depends o= n Git, >>> which is itself motivated by the fact that Git supports >>> shallow clones and libgit2/Guile-Git doesn=E2=80=99t. > ... >> Personally, I do not have a strong opinion about the Big Plan=E2=84=A2. = I note >> that the introduction of Git as a hard dependency is a slippery slope >> considering the current state of libgit2. Here, it starts with =E2=80= =9Cgit >> clone=E2=80=9D, then =E2=80=9Cgit gc=E2=80=9D (unsupported by libgit2) i= s also in the pipes >> (#65720 [1]). > > What about making git an optional dependency, and only calling out to > "git gc" if git is available in PATH? Maybe possible also with shallow > clones? > > Then you have the best/worst of both worlds! Speaking to the worst, you > have at least two disparate codepaths for a seemingly similar operation, > and that might be annoying... > > live well, > vagrant > > [[End of PGP Signed Part]] For what it's worth, I wrote a small (incomplete) tool for some commit analysis that used specific --format arguments that were easy to parse. It's not especially difficult.