From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Wingo <wingo@igalia.com>
Subject: Re: cross-compiling in core-updates
Date: Tue, 02 May 2017 21:20:26 +0200
Message-ID: <cuc60hjcbgl.fsf@igalia.com>
References: <LTDil8RWr0Ul88EYrPBgY3@YlCDpmvAINTp0ww1h012U>
	<CAFtzXzOYEhykHhisSAmqVoxUhqWJEZiE7MD1Bkxvj+OhZSRWRw@mail.gmail.com>
	<20170425222658.785f93da@sf>
	<a0d455fa-9022-1621-882f-0f502ad9603e@gmail.com>
	<cucinljd92q.fsf@igalia.com> <20170502200309.2ee511e8@sf>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58661)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wingo@igalia.com>) id 1d5dLp-0001PZ-2C
	for Guix-devel@gnu.org; Tue, 02 May 2017 15:20:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wingo@igalia.com>) id 1d5dLj-00076G-KQ
	for Guix-devel@gnu.org; Tue, 02 May 2017 15:20:44 -0400
In-Reply-To: <20170502200309.2ee511e8@sf> (Sergei Trofimovich's message of
	"Tue, 2 May 2017 20:03:15 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Sergei Trofimovich <slyfox@inbox.ru>
Cc: Guix-devel <Guix-devel@gnu.org>, rennes <rennes@openmailbox.org>

On Tue 02 May 2017 21:03, Sergei Trofimovich <slyfox@inbox.ru> writes:

> Yay! The following patch makes bash-minimal compile fine!
>
> diff --git a/gnu/packages/bash.scm b/gnu/packages/bash.scm
> index ef22728a9..38aa1786e 100644
> --- a/gnu/packages/bash.scm
> +++ b/gnu/packages/bash.scm
> @@ -213,7 +213,7 @@ without modification.")
>      (arguments
> -     (let ((args `(#:modules ((guix build gnu-build-system)
> +     (let ((args `(,@(package-arguments bash)
> +                   #:modules ((guix build gnu-build-system)
>                                (guix build utils)
>                                (srfi srfi-1)
> -                              (srfi srfi-26))
> -                   ,@(package-arguments bash))))
> +                              (srfi srfi-26)))))
>         (substitute-keyword-arguments args

Excellent!  Thank you and Rennes and Manolis for the excellent bug
sleuthing.

> I'm afraid I understood almost nothing about your comments of 
> visibility. The only thing I've got is that keyword argument order
> matters :)

Sorry for the digression!  I didn't help things by using the term
"keyword" in two different ways :P

> Would the similar ordering change have the no-op effect in master
> branch or does it mean core-updates should do this reordering while
> master should not?

Yes, it should have no effect.  On the other hand I don't know if it
would cause a whole-world rebuild; maybe that would be a reason to not
apply it to master?  I defer to Ludovic here.

Andy