From: Andy Wingo <wingo@igalia.com>
To: Sergei Trofimovich <slyfox@inbox.ru>
Cc: Guix-devel <Guix-devel@gnu.org>, rennes <rennes@openmailbox.org>
Subject: Re: cross-compiling in core-updates
Date: Tue, 02 May 2017 21:20:26 +0200 [thread overview]
Message-ID: <cuc60hjcbgl.fsf@igalia.com> (raw)
In-Reply-To: <20170502200309.2ee511e8@sf> (Sergei Trofimovich's message of "Tue, 2 May 2017 20:03:15 +0100")
On Tue 02 May 2017 21:03, Sergei Trofimovich <slyfox@inbox.ru> writes:
> Yay! The following patch makes bash-minimal compile fine!
>
> diff --git a/gnu/packages/bash.scm b/gnu/packages/bash.scm
> index ef22728a9..38aa1786e 100644
> --- a/gnu/packages/bash.scm
> +++ b/gnu/packages/bash.scm
> @@ -213,7 +213,7 @@ without modification.")
> (arguments
> - (let ((args `(#:modules ((guix build gnu-build-system)
> + (let ((args `(,@(package-arguments bash)
> + #:modules ((guix build gnu-build-system)
> (guix build utils)
> (srfi srfi-1)
> - (srfi srfi-26))
> - ,@(package-arguments bash))))
> + (srfi srfi-26)))))
> (substitute-keyword-arguments args
Excellent! Thank you and Rennes and Manolis for the excellent bug
sleuthing.
> I'm afraid I understood almost nothing about your comments of
> visibility. The only thing I've got is that keyword argument order
> matters :)
Sorry for the digression! I didn't help things by using the term
"keyword" in two different ways :P
> Would the similar ordering change have the no-op effect in master
> branch or does it mean core-updates should do this reordering while
> master should not?
Yes, it should have no effect. On the other hand I don't know if it
would cause a whole-world rebuild; maybe that would be a reason to not
apply it to master? I defer to Ludovic here.
Andy
next prev parent reply other threads:[~2017-05-02 19:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 11:44 cross-compiling in core-updates rennes
2017-04-25 14:10 ` Manolis Ragkousis
2017-04-25 21:26 ` Sergei Trofimovich
2017-04-28 19:04 ` Manolis Ragkousis
2017-05-02 7:14 ` Andy Wingo
2017-05-02 19:03 ` Sergei Trofimovich
2017-05-02 19:20 ` Andy Wingo [this message]
2017-05-03 19:32 ` rennes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cuc60hjcbgl.fsf@igalia.com \
--to=wingo@igalia.com \
--cc=Guix-devel@gnu.org \
--cc=rennes@openmailbox.org \
--cc=slyfox@inbox.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).