[PATCH 0/1] Don't bootstrap ncmpcpp?

[PATCH 0/1] Don't bootstrap ncmpcpp?

[Leo Famulari]

I wondered why we re-bootstrap ncmpcpp, so I tried to build without
doing it. It works fine for me.

Does anyone know why we started doing it? The mailing list thread where
the patch was submitted doesn't address it [0].

I've attached a patch to stop doing it and remove the unused inputs. I'm
not sure how to word the commit message.

[0]
http://lists.gnu.org/archive/html/guix-devel/2015-02/msg00864.html

Leo Famulari (1):
  gnu: ncmpcpp: Remove bootstrapping inputs.

 gnu/packages/mpd.scm | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

-- 
2.7.4

[PATCH 1/1] gnu: ncmpcpp: Remove bootstrapping inputs.

[Leo Famulari]

* gnu/packages/mpd.scm (ncmpcpp)[arguments]: Remove 'autogen' phase.
[native-inputs]: Remove autoconf, automake, and libtool.
---
 gnu/packages/mpd.scm | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 63cb16f..4860325 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -42,7 +42,6 @@
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
-  #:use-module (gnu packages autotools)
   #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages databases)
   #:use-module (gnu packages video)
@@ -198,19 +197,10 @@ terminal using ncurses.")
               ("taglib" ,taglib)
               ("icu4c" ,icu4c)))
     (native-inputs
-     `(("pkg-config" ,pkg-config)
-       ("automake" ,automake)
-       ("autoconf" ,autoconf)
-       ("libtool" ,libtool)))
+     `(("pkg-config" ,pkg-config)))
     (arguments
      '(#:configure-flags
-       '("BOOST_LIB_SUFFIX=" "--with-taglib")
-       #:phases
-       (modify-phases %standard-phases
-        (add-after 'unpack 'autogen
-         (lambda _
-           (setenv "NOCONFIGURE" "true")
-           (zero? (system* "sh" "autogen.sh")))))))
+       '("BOOST_LIB_SUFFIX=" "--with-taglib")))
     (synopsis "Featureful ncurses based MPD client inspired by ncmpc")
     (description "Ncmpcpp is an mpd client with a UI very similar to ncmpc,
 but it provides new useful features such as support for regular expressions
-- 
2.7.4

Re: [PATCH 1/1] gnu: ncmpcpp: Remove bootstrapping inputs.

[Ludovic Courtès]

Leo Famulari <leo@famulari.name> skribis:

> * gnu/packages/mpd.scm (ncmpcpp)[arguments]: Remove 'autogen' phase.
> [native-inputs]: Remove autoconf, automake, and libtool.

It’s a good idea.  Maybe that was needed for an older version, or maybe
that was never actually needed.

Thanks!

Ludo’.