unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: guix-devel@gnu.org
Subject: [PATCH 0/1] Remove an unused patch?
Date: Fri, 19 Feb 2016 23:22:30 -0500	[thread overview]
Message-ID: <cover.1455942085.git.leo@famulari.name> (raw)

The patch file 'cpio-gets-undeclared.patch' was "de-applied" to the cpio
sources when we upgraded cpio to 2.12 (92d0fcb6dc5). But, it was never
deleted or removed from gnu-system.am.

So, should we delete it or re-apply it? I guess the answer depends on
whether or not cpio still uses gets().

I searched for use of gets() in the cpio-2.12 source tree like this:
$ grep -rI 'gets ('
$ grep -rI 'gets('

All the results were uses of fgets(). Is that reasonable method of
searching or should I continue with some other technique?

Leo Famulari (1):
  gnu: cpio: Remove unused patch.

 gnu-system.am                                   |  1 -
 gnu/packages/patches/cpio-gets-undeclared.patch | 45 -------------------------
 2 files changed, 46 deletions(-)
 delete mode 100644 gnu/packages/patches/cpio-gets-undeclared.patch

-- 
2.7.1

             reply	other threads:[~2016-02-20  4:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-20  4:22 Leo Famulari [this message]
2016-02-20  4:22 ` [PATCH 1/1] gnu: cpio: Remove unused patch Leo Famulari
2016-02-26  0:20   ` Mark H Weaver
2016-02-26  1:32     ` Leo Famulari
2016-03-05 16:14 ` [PATCH 0/1] Remove an unused patch? Andreas Enge
2016-03-05 21:57   ` Ludovic Courtès
2016-03-05 22:08     ` Leo Famulari
2016-03-06 12:49       ` Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1455942085.git.leo@famulari.name \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).