From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: [PATCH 0/1] Add lz4 (C implementation) Date: Wed, 9 Sep 2015 17:04:11 -0400 Message-ID: Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZmWU-00046v-3W for guix-devel@gnu.org; Wed, 09 Sep 2015 17:03:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZmWR-0003bD-Du for guix-devel@gnu.org; Wed, 09 Sep 2015 17:03:18 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:46733) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZmWR-0003aP-18 for guix-devel@gnu.org; Wed, 09 Sep 2015 17:03:15 -0400 Received: from jasmine.lan (c-69-249-5-231.hsd1.pa.comcast.net [69.249.5.231]) by mail.messagingengine.com (Postfix) with ESMTPA id 39177C00285 for ; Wed, 9 Sep 2015 17:03:13 -0400 (EDT) List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: guix-devel@gnu.org This patch adds the C reference implementation of the lz4 compression algorithm. I'm looking for advice regarding the tests. The tests take >30 minutes on my on my quad-core i5 with 8 gigabytes of RAM and they require Valgrind as a native-input. This seems excessive to me but if users install binary substitutes, they won't run the tests or need to install Valgrind, right? And if distributions won't test software, then who will? It might be possible to cherry-pick which tests are used. `make test` is a recursive call to a Makefile in the programs/ subdirectory of the tarball. That Makefile builds the lists of test to run. For this reason, setting 'test-target' in the package definition won't work because it works on the top-level Makefile. If someone knows how to specify the test-targets on the second Makefile, we could ask upstream for advice on what tests to exclude. Also, I have sent a message to the lz4 author asking if tests are expected to fail when run in parallel. I expect the answer is yes, but I'd like to be sure. Leo Famulari (1): gnu: Add lz4. gnu/packages/compression.scm | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) -- 2.4.3