From: "Siniša Biđin" <sinisa@bidin.eu>
To: ludo@gnu.org
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add cabal-install.
Date: Wed, 26 Aug 2015 05:59:51 +0200 [thread overview]
Message-ID: <cfa59b2e9d833cd032d7d19e2ccaf243@bidin.eu> (raw)
In-Reply-To: <87lhczf49h.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 903 bytes --]
On 2015-08-25 23:27, ludo@gnu.org wrote:
> Please add a copyright line for yourself.
Added.
>> + (arguments `(#:tests? #f))
>
> Could you add a comment above explaining why tests are disabled? (We
> generally avoid that unless there’s a good reason, sometimes because
> running the tests would be unnecessarily complex.)
I've added a simple "FIXME" comment to that line, similar to how the
other haskell.scm packages do it. The reason is that the ghc-* libs
needed to enable testing haven't been imported yet. I've attempted to
fix that, but got tangled up in conflicting dependency versions and
gave up for now.
>> + (synopsis "The command-line interface for Cabal and Hackage.")
>
> Remove “The” and the period (and make sure to run ‘guix lint’ ;-)).
Also fixed.
> Could you send an updated patch?
Sure, you'll find it attached.
Thanks,
Siniša
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-cabal-install.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-cabal-install.patch, Size: 2047 bytes --]
From a8e3990be14e4259e7e8beeeacef744cee7e6cae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sini=C5=A1a=20Bi=C4=91in?= <sinisa@bidin.eu>
Date: Tue, 18 Aug 2015 16:19:11 +0200
Subject: [PATCH] gnu: Add cabal-install.
* gnu/packages/haskell.scm (cabal-install): New variable.
---
gnu/packages/haskell.scm | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index 33eb1b5..f866c1d 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -1,5 +1,6 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2015 Federico Beffa <beffa@fbengineering.ch>
+;;; Copyright © 2015 Siniša Biđin <sinisa@bidin.eu>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -238,6 +239,37 @@
interactive environment for the functional language Haskell.")
(license bsd-3)))
+(define-public cabal-install
+ (package
+ (name "cabal-install")
+ (version "1.18.1.0")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "http://hackage.haskell.org/package/cabal-install/cabal-install-"
+ version
+ ".tar.gz"))
+ (sha256
+ (base32 "1r1shhvnpgxf91rmbv3wa1rkd24plbgr6bpz3aj80ir0z3zbdayn"))))
+ (arguments `(#:tests? #f)) ; FIXME: testing libraries are missing.
+ (build-system haskell-build-system)
+ (propagated-inputs
+ `(("ghc-http" ,ghc-http)
+ ("ghc-mtl" ,ghc-mtl)
+ ("ghc-network-uri" ,ghc-network-uri)
+ ("ghc-network" ,ghc-network)
+ ("ghc-random" ,ghc-random)
+ ("ghc-stm" ,ghc-stm)
+ ("ghc-zlib" ,ghc-zlib)))
+ (home-page "http://www.haskell.org/cabal/")
+ (synopsis "Command-line interface for Cabal and Hackage")
+ (description
+ "The cabal command-line program simplifies the process of managing
+Haskell software by automating the fetching, configuration, compilation and
+installation of Haskell libraries and programs.")
+ (license bsd-3)))
+
(define-public ghc-mtl
(package
(name "ghc-mtl")
--
2.5.0
next prev parent reply other threads:[~2015-08-26 3:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 14:32 [PATCH] gnu: Add cabal-install Siniša Biđin
2015-08-25 21:27 ` Ludovic Courtès
2015-08-26 3:59 ` Siniša Biđin [this message]
2015-08-28 9:00 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfa59b2e9d833cd032d7d19e2ccaf243@bidin.eu \
--to=sinisa@bidin.eu \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).