From: Eric Bavier <ericbavier@openmailbox.org>
To: Andy Wingo <wingo@igalia.com>
Cc: guix-devel@gnu.org, Alex Kost <alezost@gmail.com>
Subject: Re: Specifying package patches in a more convenient form
Date: Thu, 07 Apr 2016 09:41:34 -0500 [thread overview]
Message-ID: <ce2643e8e548a8c507e68e5324d6140a@openmailbox.org> (raw)
In-Reply-To: <877fg9bukd.fsf@igalia.com>
On 2016-04-07 05:08, Andy Wingo wrote:
> On Thu 07 Apr 2016 11:52, Alex Kost <alezost@gmail.com> writes:
>
>> Eric Bavier (2016-04-06 17:57 +0300) wrote:
>>
>>> On Wed, 06 Apr 2016 15:13:47 +0300
>>> Alex Kost <alezost@gmail.com> wrote:
>> [...]
>>>> > + "1lgghck46p33z3hg8dnl76jryig4fh6d8rhzms837zp7x4hyfkv4"))
>>>> > + (patches (map search-patch '("ttfautohint-source-date-epoch.patch")))))
>>>>
>>>> Since it's just a single patch, I don't see a reason to use 'map'
>>>> here.
>>>
>>> Just that it's less to change if more patches are added later. The
>>> same has been used in other packages.
>>
>> I strongly disagree with this policy. More patches may never be
>> added,
>> but mapping through a list of a single element looks redundant for me.
Sure. I'm persuaded.
>
> What if the "patches" field just applied `search-path' to each of the
> items in the list if the path is not absolute? Use
> `absolute-file-name?' to check if this is needed or not.
This sounds like a promising idea to me.
--
`~Eric
next prev parent reply other threads:[~2016-04-07 14:42 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 4:32 [PATCH 1/9] gnu: Add ttfautohint ericbavier
2016-04-06 4:32 ` [PATCH 2/9] gnu: Add woff-tools ericbavier
2016-04-07 6:18 ` Efraim Flashner
2016-04-07 14:25 ` Eric Bavier
2016-04-13 21:37 ` Ludovic Courtès
2016-04-06 4:32 ` [PATCH 3/9] gnu: Add ttf2eot ericbavier
2016-04-07 6:24 ` Efraim Flashner
2016-04-07 14:30 ` Eric Bavier
2016-04-08 3:49 ` Eric Bavier
2016-04-13 21:39 ` Ludovic Courtès
2016-04-06 4:32 ` [PATCH 4/9] gnu: Add brotli ericbavier
2016-04-13 21:44 ` Ludovic Courtès
2016-04-06 4:32 ` [PATCH 5/9] gnu: Add woff2 ericbavier
2016-04-06 4:32 ` [PATCH 6/9] gnu: fontforge: Make SVG builds reproducible ericbavier
2016-04-06 17:36 ` Leo Famulari
2016-04-06 17:44 ` Eric Bavier
2016-04-06 17:56 ` Leo Famulari
2016-04-06 4:32 ` [PATCH 7/9] gnu: Add font-fantasque-sans ericbavier
2016-04-06 4:33 ` [PATCH 8/9] gnu: fontforge: Use modify-phases ericbavier
2016-04-06 4:33 ` [PATCH 9/9] gnu: fontforge: Install 'showttf' tool ericbavier
2016-04-06 12:13 ` [PATCH 1/9] gnu: Add ttfautohint Alex Kost
2016-04-06 14:57 ` Eric Bavier
2016-04-07 9:52 ` Specifying package patches in a more convenient form Alex Kost
2016-04-07 10:08 ` Andy Wingo
2016-04-07 14:41 ` Eric Bavier [this message]
2016-04-08 8:05 ` Alex Kost
2016-04-09 14:43 ` Ludovic Courtès
2016-04-07 21:54 ` Ludovic Courtès
2016-04-09 8:22 ` Alex Kost
2016-04-09 11:42 ` Andreas Enge
2016-04-09 16:40 ` Alex Kost
2016-04-13 21:40 ` [PATCH 1/9] gnu: Add ttfautohint Ludovic Courtès
2016-04-13 21:36 ` Ludovic Courtès
2016-04-14 14:43 ` Eric Bavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce2643e8e548a8c507e68e5324d6140a@openmailbox.org \
--to=ericbavier@openmailbox.org \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=wingo@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).